Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: vm/flow_graph_compiler_ia32.cc

Issue 10572029: - Fix the type test failure for implicit native closures. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/dart_api_impl_test.cc ('k') | vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_compiler_ia32.cc
===================================================================
--- vm/flow_graph_compiler_ia32.cc (revision 8816)
+++ vm/flow_graph_compiler_ia32.cc (working copy)
@@ -122,8 +122,9 @@
LocalScope* scope = parsed_function().node_sequence()->scope();
const int num_fixed_params = function.num_fixed_parameters();
const int num_opt_params = function.num_optional_parameters();
+ int implicit_this_param_pos = is_native_instance_closure ? -1 : 0;
ASSERT(parsed_function().first_parameter_index() ==
- ParsedFunction::kFirstLocalSlotIndex);
+ ParsedFunction::kFirstLocalSlotIndex + implicit_this_param_pos);
// Copy positional arguments.
// Check that no fewer than num_fixed_params positional arguments are passed
// in and that no more than num_params arguments are passed in.
@@ -150,7 +151,6 @@
// Let EDI point to the last copied positional argument, i.e. to
// fp[ParsedFunction::kFirstLocalSlotIndex - (num_pos_args - 1)].
- int implicit_this_param_pos = is_native_instance_closure ? -1 : 0;
const int index =
ParsedFunction::kFirstLocalSlotIndex + 1 + implicit_this_param_pos;
// First copy captured receiver if function is an implicit native closure.
« no previous file with comments | « vm/dart_api_impl_test.cc ('k') | vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698