Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: vm/flow_graph_builder.cc

Issue 10568007: Fix bailout from the optimizing-mode compiler and put SSA construction under a flag. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/compiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/flow_graph_builder.cc
===================================================================
--- vm/flow_graph_builder.cc (revision 8766)
+++ vm/flow_graph_builder.cc (working copy)
@@ -24,6 +24,7 @@
"Eliminate type checks when allowed by static type analysis");
DEFINE_FLAG(bool, print_ast, false, "Print abstract syntax tree.");
DEFINE_FLAG(bool, print_flow_graph, false, "Print the IR flow graph.");
+DEFINE_FLAG(bool, use_ssa, false, "Use SSA form");
DECLARE_FLAG(bool, enable_type_checks);
@@ -2340,7 +2341,7 @@
for (intptr_t i = 0; i < block_count; ++i) {
postorder_block_entries_[i]->set_block_id(block_count - i - 1);
}
- if (for_optimized) {
+ if (for_optimized && FLAG_use_ssa) {
GrowableArray<BitVector*> dominance_frontier;
ComputeDominators(&preorder_block_entries_, &parent, &dominance_frontier);
InsertPhis(preorder_block_entries_,
@@ -2366,6 +2367,10 @@
printer.PrintFunction();
}
}
+
+ if (for_optimized && FLAG_use_ssa) {
+ Bailout("No SSA code generation support.");
+ }
}
« no previous file with comments | « vm/compiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698