Issue 10568003: Add support for GL_CHROMIUM_consistent_uniform_locations

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+719 lines, -252 lines)			Patch
A	gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt	View	4	1 chunk	+86 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View		3 chunks	+10 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.cc	View	1 2 3	3 chunks	+74 lines, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_unittest.cc	View		2 chunks	+63 lines, -1 line	0 comments	Download
M	gpu/command_buffer/cmd_buffer_functions.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.cc	View	1 2 3	1 chunk	+23 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils_unittest.cc	View	1 2 3 4 5	2 chunks	+12 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View		30 chunks	+30 lines, -30 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View		24 chunks	+24 lines, -24 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h	View		73 chunks	+83 lines, -96 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager.h	View		3 chunks	+0 lines, -10 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager.cc	View		7 chunks	+50 lines, -44 lines	0 comments	Download
M	gpu/command_buffer/service/program_manager_unittest.cc	View		5 chunks	+75 lines, -20 lines	0 comments	Download
M	gpu/command_buffer/service/test_helper.cc	View		5 chunks	+42 lines, -17 lines	0 comments	Download
A	gpu/command_buffer/tests/gl_consistent_uniform_locations_unittest.cc	View	4	1 chunk	+103 lines, -0 lines	0 comments	Download
M	gpu/gpu_common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/khronos/GLES2/gl2ext.h	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	third_party/khronos/README.chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

8 years, 6 months ago (2012-06-18 18:58:03 UTC) #2

lgtm

http://codereview.chromium.org/10568003/diff/8002/gpu/command_buffer/client/g...
File gpu/command_buffer/client/gles2_implementation.cc (right):

http://codereview.chromium.org/10568003/diff/8002/gpu/command_buffer/client/g...
gpu/command_buffer/client/gles2_implementation.cc:3332: scoped_array<GLint>
reverse_map(new int[count]);
nit: int->GLint

http://codereview.chromium.org/10568003/diff/8002/gpu/command_buffer/common/g...
File gpu/command_buffer/common/gles2_cmd_utils.cc (right):

http://codereview.chromium.org/10568003/diff/8002/gpu/command_buffer/common/g...
gpu/command_buffer/common/gles2_cmd_utils.cc:763: // the location of
"someuniform[1]" is not 'n' more than "someuniform[0]".
nit: [1]->[n]

Expand Messages | Collapse Messages