Mouse lock and fullscreen exit upon reload.

Mouse lock and fullscreen exit upon reload.

BUG=132669, 130301

[jeremya, 2012-06-16 06:25:50]

Can this not be caught at a lower level, like "whenever a navigation occurs"?

[koz (OOO until 15th September), 2012-06-18 03:23:13]

FWIW, I added a reload test to my other change
(https://chromiumcodereview.appspot.com/10378061) and it passes. I guess the
question is whether it's safe to assume that reload is always followed by a
navigation. I can't think of a case where it wouldn't be off the top of my head.

[scheib, 2012-06-18 03:40:32]

Works for me - I'll re-factor this change to use the navigation
notifications that Koz's other change is using.
http://codereview.chromium.org/10378061/

Backstory: I started this way to replicate the behavior of Safari and
WebKit nightly: reload is blocked when a page is fullscreen. However, Glen
decided we should go the route of FireFox and permit the reload, exiting FS
and ML.

[yzshen1, 2012-06-18 16:22:05]

http://codereview.chromium.org/10567002/diff/1008/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/10567002/diff/1008/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:4884: return;
Why the following actions are not needed when fullscreen controller returns
true? Besides, I read the code and saw that the method always returns false:

- Do you plan to have the method return true in a future change?
- If you have such a plan, that will affect reload behavior. I don't think that
is intended, since in bug 130301, you wrote "Expected: Mouse is unlocked, page
is reloaded."

http://codereview.chromium.org/10567002/diff/1008/chrome/browser/ui/fullscree...
File chrome/browser/ui/fullscreen_controller.h (right):

http://codereview.chromium.org/10567002/diff/1008/chrome/browser/ui/fullscree...
chrome/browser/ui/fullscreen_controller.h:92: // User Interaction Handlers. They
Return true to block default action.
nit: Please use lower case for 'interaction' and 'handlers'.

http://codereview.chromium.org/10567002/diff/1008/chrome/browser/ui/fullscree...
chrome/browser/ui/fullscreen_controller.h:94: bool HandleUserPressedReload();
[I don't know the exact answer, but would like to make sure you have considered
this.]
What about script-triggered reload? Why it should behave differently? Is
Browser::ReloadInternal() only called by explicit user actions?

[koz (OOO until 15th September), 2012-06-19 00:38:48]

On 2012/06/18 03:40:32, scheib wrote:
> Works for me - I'll re-factor this change to use the navigation
> notifications that Koz's other change is using.
> http://codereview.chromium.org/10378061/
> 
> Backstory: I started this way to replicate the behavior of Safari and
> WebKit nightly: reload is blocked when a page is fullscreen. However, Glen
> decided we should go the route of FireFox and permit the reload, exiting FS
> and ML.

Ah, unfortunately the Reload() test I wrote is really, really flaky. Like 50%
pass rate on my linux box (I discovered this this morning after rebasing). Maybe
the "easy way" isn't so ideal after all. Sorry for leading you astray here.