Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 10566028: Fix build/android/run_tests.sh (Closed)

Created:
8 years, 6 months ago by digit1
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix build/android/run_tests.sh Ensure run_tests.sh works properly on all devices by putting temporary test files under /data/local/tmp, instead of /data/local/ which restricted on some device builds. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142969

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M build/android/flag_changer.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/test_package_executable.py View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Philippe
lgtm
8 years, 6 months ago (2012-06-18 15:21:25 UTC) #1
digit1
fyi, the second patch updates the copyright to avoid a presubmit warning.
8 years, 6 months ago (2012-06-19 12:03:16 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-06-19 12:03:59 UTC) #3
digit1
Do we have any commiter that can lgtm this change? Otherwise I can't submit it. ...
8 years, 6 months ago (2012-06-19 12:04:57 UTC) #4
bulach
lgtm, thanks!
8 years, 6 months ago (2012-06-19 12:32:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/10566028/2001
8 years, 6 months ago (2012-06-19 12:39:56 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 16:22:32 UTC) #7
Change committed as 142969

Powered by Google App Engine
This is Rietveld 408576698