Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10566022: Click on empty space clears selection in single selection list on Mac and Chrome OS. (Closed)

Created:
8 years, 6 months ago by SeRya
Modified:
8 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Click on empty space clears selection in single selection list on Mac and Chrome OS. Also Ctrl+Up/Down don't move lead item on Chrome OS. BUG=132881 TEST=Manual test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
SeRya
8 years, 6 months ago (2012-06-18 09:07:30 UTC) #1
arv (Not doing code reviews)
LGTM I'm a biut surprised that we are diverging from the Windows behavior here. Most ...
8 years, 6 months ago (2012-06-18 16:42:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10566022/1
8 years, 6 months ago (2012-06-18 20:24:26 UTC) #3
commit-bot: I haz the power
Try job failure for 10566022-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 6 months ago (2012-06-18 20:38:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10566022/1
8 years, 6 months ago (2012-06-19 04:16:33 UTC) #5
commit-bot: I haz the power
Try job failure for 10566022-1 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
8 years, 6 months ago (2012-06-19 07:22:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10566022/1
8 years, 6 months ago (2012-06-19 07:57:09 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 10:30:59 UTC) #8
Try job failure for 10566022-1 (retry) on win_rel for step
"chrome_frame_net_tests".
It's a second try, previously, step "chrome_frame_net_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698