Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4250)

Unified Diff: chrome/renderer/resources/extensions/event.js

Issue 10566018: Initial work to remove the notion of all extension message payloads as strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removing parts of a different change. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/event.js
diff --git a/chrome/renderer/resources/extensions/event.js b/chrome/renderer/resources/extensions/event.js
index a69e47428c43ad2515a2f8091be4ea011ab1f3a2..ad482d4f2794b2f3aef59b45d90bdb4c35eb31ec 100644
--- a/chrome/renderer/resources/extensions/event.js
+++ b/chrome/renderer/resources/extensions/event.js
@@ -139,7 +139,12 @@
chromeHidden.Event.dispatchJSON = function(name, args) {
if (attachedNamedEvents[name]) {
if (args) {
- args = chromeHidden.JSON.parse(args);
+ // This is an antiquity. Until all callers of dispatchJSON use actual
asargent_no_longer_on_chrome 2012/06/18 16:25:30 You can add TODO(asargent) to this comment. (There
Garret Kelly 2012/06/18 18:15:01 Done.
+ // values, this must remain here to catch the cases where a caller has
+ // hard-coded a JSON string to pass in.
+ if (typeof(args) == "string") {
+ args = chromeHidden.JSON.parse(args);
+ }
if (eventArgumentMassagers[name])
eventArgumentMassagers[name](args);
}

Powered by Google App Engine
This is Rietveld 408576698