Issue 10566014: Change PP_Flash_BrowserOperations_SiteSetting.site from PP_Var to const char*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10566014: Change PP_Flash_BrowserOperations_SiteSetting.site from PP_Var to const char*. (Closed)

Created:
8 years, 6 months ago by yzshen1

Modified:
8 years, 6 months ago

Reviewers:
brettw, noelallen1

CC:
chromium-reviews, jochen+watch-content_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change PP_Flash_BrowserOperations_SiteSetting.site from PP_Var to const char*. This change is needed because PP_Var cannot be used in a broker process. This change also adds support for cstr_t in ppapi IDL files. BUG=112190 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142670

Patch Set 1 #

Patch Set 2 : remove assert_size #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -45 lines)			Patch
M	content/ppapi_plugin/broker_process_dispatcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/ppapi_plugin/broker_process_dispatcher.cc	View		11 chunks	+17 lines, -24 lines	0 comments	Download
M	ppapi/api/pp_stdint.idl	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ppapi/api/private/ppp_flash_browser_operations.idl	View	1	6 chunks	+6 lines, -9 lines	0 comments	Download
M	ppapi/c/private/ppp_flash_browser_operations.h	View	1	5 chunks	+7 lines, -11 lines	0 comments	Download
M	ppapi/generators/idl_c_proto.py	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yzshen1

Hi, Brett and Noel. Would you please take a look? Thanks! Noel: pp_stdint.idl and idl_c_proto.py ...

8 years, 6 months ago (2012-06-15 23:10:45 UTC) #1

lgtm

Expand Messages | Collapse Messages