Detect if user closes the pref-pane without disabling Chromoting

Detect if user closes the pref-pane without disabling Chromoting


BUG=129616
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142544

[Lambros, 2012-06-15 22:14:58]

I know I've added yet another constant to two files.  I plan to clean this up in
my next CL :)

[Jamie, 2012-06-15 22:34:55]

As I mentioned off-line, it might be better to send a failed notification, in
which case this CL can be a lot simpler.

http://codereview.chromium.org/10566013/diff/1/remoting/host/me2me_preference...
File remoting/host/me2me_preference_pane.mm (right):

http://codereview.chromium.org/10566013/diff/1/remoting/host/me2me_preference...
remoting/host/me2me_preference_pane.mm:48: #define kUserCanceledNotificationName
kServiceName ".user_canceled"
Can we call this update_canceled for consistency with the other two?

http://codereview.chromium.org/10566013/diff/1/remoting/host/me2me_preference...
remoting/host/me2me_preference_pane.mm:345: [self
notifyPlugin:kUserCanceledNotificationName];
This feels inconsistent. Why send a failed notification for the "start/change
PIN" pane, but a canceled notification for the "stop" pane?

http://codereview.chromium.org/10566013/diff/1/remoting/host/me2me_preference...
remoting/host/me2me_preference_pane.mm:771: [self
notifyPlugin:kUserCanceledNotificationName];
Under what circumstances can this happen? Would it make sense to send an error
notification instead?

[Lambros, 2012-06-15 22:55:06]

This simpler CL addresses all comments :)

[Jamie, 2012-06-15 23:00:02]

lgtm

http://codereview.chromium.org/10566013/diff/5001/remoting/host/me2me_prefere...
File remoting/host/me2me_preference_pane.mm (right):

http://codereview.chromium.org/10566013/diff/5001/remoting/host/me2me_prefere...
remoting/host/me2me_preference_pane.mm:757: [self
notifyPlugin:kUpdateFailedNotificationName];
I don't think it matters either way, but why have you moved this to happen
before remove()?

[Lambros, 2012-06-15 23:05:14]

http://codereview.chromium.org/10566013/diff/5001/remoting/host/me2me_prefere...
File remoting/host/me2me_preference_pane.mm (right):

http://codereview.chromium.org/10566013/diff/5001/remoting/host/me2me_prefere...
remoting/host/me2me_preference_pane.mm:757: [self
notifyPlugin:kUpdateFailedNotificationName];
On 2012/06/15 23:00:02, Jamie wrote:
> I don't think it matters either way, but why have you moved this to happen
> before remove()?
Wasn't intentional, undone! :)

[commit-bot: I haz the power, 2012-06-15 23:09:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10566013/1...

[commit-bot: I haz the power, 2012-06-16 00:45:00]

Change committed as 142544