Issue 10566003: ash: Fix arrow color for the uber-tray popup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10566003: ash: Fix arrow color for the uber-tray popup. (Closed)

Created:
8 years, 6 months ago by sadrul

Modified:
8 years, 6 months ago

Reviewers:
jennyz, Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Fix arrow color for the uber-tray popup. The arrow-color should have the same color as the background color of the attached view. Also, do not change background color on hover for detailed/notification views. BUG=129428 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142428

Patch Set 1 : . #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : indent #

Patch Set 4 : tot-merge #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -11 lines)			Patch
M	ash/system/tray/system_tray_bubble.cc	View	1 2 3	3 chunks	+11 lines, -6 lines	0 comments	Download
M	ash/system/tray/tray_bubble_view.cc	View	1 2 3	5 chunks	+18 lines, -1 line	0 comments	Download
M	ash/system/tray/tray_views.cc	View	1 2 3	1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jennyz

lgtm with a small nit. http://codereview.chromium.org/10566003/diff/4001/ash/system/tray/tray_views.cc File ash/system/tray/tray_views.cc (right): http://codereview.chromium.org/10566003/diff/4001/ash/system/tray/tray_views.cc#newcode430 ash/system/tray/tray_views.cc:430: kHeaderBackgroundColorDark)); line 429 -430: ...

8 years, 6 months ago (2012-06-15 17:51:39 UTC) #2

sadrul

8 years, 6 months ago (2012-06-15 17:56:22 UTC) #4

http://codereview.chromium.org/10566003/diff/4001/ash/system/tray/tray_views.cc
File ash/system/tray/tray_views.cc (right):

http://codereview.chromium.org/10566003/diff/4001/ash/system/tray/tray_views....
ash/system/tray/tray_views.cc:430: kHeaderBackgroundColorDark));
On 2012/06/15 17:51:39, jennyz wrote:
> line 429 -430: Should have 2 more leading space for indent for continue line.

Done.

Expand Messages | Collapse Messages