Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 1056553002: First step towards moving builder configurations out of the recipe module. (Closed)

Created:
5 years, 8 months ago by Adrian Kuegel
Modified:
5 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

First step towards moving builder configurations out of the recipe module. As a first step, allow each recipe to specify its own builder configurations. BUG=472611

Patch Set 1 #

Patch Set 2 : Only pass those builders that are necessary. #

Patch Set 3 : Sync to ToT and fix chromium example. #

Patch Set 4 : Get rid of builders property in chromium recipe_module. #

Patch Set 5 : Small fixes. #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -42 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 2 3 4 8 chunks +7 lines, -19 lines 4 comments Download
M scripts/slave/recipe_modules/chromium/example.py View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/steps.py View 1 2 3 4 chunks +7 lines, -4 lines 3 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipes/android/perf.py View 1 2 3 3 chunks +7 lines, -2 lines 2 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisect.py View 1 2 3 2 chunks +10 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 1 2 3 3 chunks +6 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot_legacy.py View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Adrian Kuegel
Pawel, can you please review this CL? This is the first step. As the next ...
5 years, 8 months ago (2015-04-02 15:23:03 UTC) #2
Paweł Hajdan Jr.
I'm somewhat concerned about this middle state this CL would create. Would it be much ...
5 years, 8 months ago (2015-04-03 10:12:35 UTC) #3
Adrian Kuegel
On 2015/04/03 10:12:35, Paweł Hajdan Jr. wrote: > I'm somewhat concerned about this middle state ...
5 years, 8 months ago (2015-04-22 17:02:15 UTC) #6
Paweł Hajdan Jr.
https://codereview.chromium.org/1056553002/diff/120001/scripts/slave/recipe_modules/chromium/api.py File scripts/slave/recipe_modules/chromium/api.py (left): https://codereview.chromium.org/1056553002/diff/120001/scripts/slave/recipe_modules/chromium/api.py#oldcode72 scripts/slave/recipe_modules/chromium/api.py:72: def builders(self): We still need to somehow share the ...
5 years, 8 months ago (2015-04-24 00:24:02 UTC) #7
Adrian Kuegel
Thanks for taking a look. Btw, I am waiting for https://codereview.chromium.org/1099423002/ to land before I ...
5 years, 8 months ago (2015-04-24 14:08:43 UTC) #8
Paweł Hajdan Jr.
https://codereview.chromium.org/1056553002/diff/120001/scripts/slave/recipe_modules/chromium/api.py File scripts/slave/recipe_modules/chromium/api.py (left): https://codereview.chromium.org/1056553002/diff/120001/scripts/slave/recipe_modules/chromium/api.py#oldcode72 scripts/slave/recipe_modules/chromium/api.py:72: def builders(self): On 2015/04/24 14:08:43, Adrian Kuegel wrote: > ...
5 years, 8 months ago (2015-04-27 08:59:59 UTC) #9
Adrian Kuegel
5 years, 6 months ago (2015-06-12 15:24:21 UTC) #10
This CL has become obsolete (new CL:
https://codereview.chromium.org/1185693002/) and I am closing it now.

Powered by Google App Engine
This is Rietveld 408576698