Chromium Code Reviews
Help | Chromium Project | Sign in
(49)

Issue 10565030: Fixing bugs in promotion of elements transitions (r1175). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by Toon Verwaest
Modified:
1 year, 10 months ago
Reviewers:
danno
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Fixing bugs in promotion of elements transitions (r1175).
- Fixed invalid memory access when reading enum-cache from descriptor array with elements transitions but 0 real descriptors.
- Fixed infinite recursion in the intrusive map iterator when visiting elements transitions.
- Properly cached non-fastmode elements transitions.

Committed: https://code.google.com/p/v8/source/detail?r=11841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -45 lines) Lint Patch
M src/objects.h View 3 chunks +7 lines, -8 lines 0 comments 0 errors Download
M src/objects.cc View 6 chunks +61 lines, -37 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Toon Verwaest
PTAL. Reduced version of http://codereview.chromium.org/10554011 containing only the critical fixes.
1 year, 10 months ago #1
danno
1 year, 10 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6