Chromium Code Reviews
Help | Chromium Project | Sign in
(571)

Issue 10565030: Fixing bugs in promotion of elements transitions (r1175). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by Toon Verwaest
Modified:
3 years, 1 month ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fixing bugs in promotion of elements transitions (r1175). - Fixed invalid memory access when reading enum-cache from descriptor array with elements transitions but 0 real descriptors. - Fixed infinite recursion in the intrusive map iterator when visiting elements transitions. - Properly cached non-fastmode elements transitions. Committed: https://code.google.com/p/v8/source/detail?r=11841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -45 lines) Patch
M src/objects.h View 3 chunks +7 lines, -8 lines 0 comments Download
M src/objects.cc View 6 chunks +61 lines, -37 lines 0 comments Download
Trybot results:
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL. Reduced version of http://codereview.chromium.org/10554011 containing only the critical fixes.
3 years, 1 month ago (2012-06-18 11:10:38 UTC) #1
danno
3 years, 1 month ago (2012-06-18 11:12:39 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f