Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/compiler/implementation/ssa/optimize.dart

Issue 10565025: Fix GVN for loops. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/gvn_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/optimize.dart
===================================================================
--- lib/compiler/implementation/ssa/optimize.dart (revision 8717)
+++ lib/compiler/implementation/ssa/optimize.dart (working copy)
@@ -903,6 +903,12 @@
void visitBasicBlock(HBasicBlock block, ValueSet values) {
HInstruction instruction = block.first;
+ if (block.isLoopHeader()) {
+ int flags = loopChangesFlags[block.id];
+ if (flags != 0) {
+ values.kill(flags);
+ }
+ }
while (instruction !== null) {
HInstruction next = instruction.next;
int flags = instruction.getChangesFlags();
« no previous file with comments | « no previous file | tests/language/gvn_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698