Issue 10565023: Adding warning for missing Label.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10565023: Adding warning for missing Label. (Closed)

Created:
8 years, 6 months ago by noelallen1

Modified:
8 years, 6 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Adding warning for missing Label. If a label is not specified for a source IDL file contianing interfaces then the version of the interface is assumed to be 1.0 and within the range of the version being generated. This CL adds a warning that the interface label is unspecified. BUG=106504 TBR=sehr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142633

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	ppapi/generators/idl_lint.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10565023/1

8 years, 6 months ago (2012-06-17 03:07:01 UTC) #1

Change committed as 142633

Expand Messages | Collapse Messages