Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: chrome/common/extensions/extension_manifest_constants.cc

Issue 10565017: Parse the script_badge manifest section. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Back out support for setting switches in unittests. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_manifest_constants.cc
diff --git a/chrome/common/extensions/extension_manifest_constants.cc b/chrome/common/extensions/extension_manifest_constants.cc
index 91a4259958546d245254ec43442cf6859cf7cb6e..d293ee85fcb6bb18f820ffbbba27e8a7203c08f9 100644
--- a/chrome/common/extensions/extension_manifest_constants.cc
+++ b/chrome/common/extensions/extension_manifest_constants.cc
@@ -96,6 +96,7 @@ const char kRequirements[] = "requirements";
const char kRunAt[] = "run_at";
const char kSandboxedPages[] = "sandbox.pages";
const char kSandboxedPagesCSP[] = "sandbox.content_security_policy";
+const char kScriptBadge[] = "script_badge";
const char kShiftKey[] = "shiftKey";
const char kShortcutKey[] = "shortcutKey";
const char kSignature[] = "signature";
@@ -401,6 +402,8 @@ const char kInvalidSandboxedPage[] =
"Invalid value for 'sandbox.pages[*]'.";
const char kInvalidSandboxedPagesCSP[] =
"Invalid value for 'sandbox.content_security_policy'.";
+const char kInvalidScriptBadge[] =
+ "Invalid value for 'script_badge'.";
const char kInvalidSignature[] =
"Value 'signature' is missing or invalid.";
const char kInvalidTheme[] =
@@ -481,6 +484,11 @@ const char kPlatformAppNeedsManifestVersion2[] =
"Platform apps need manifest_version set to >= 2";
const char kReservedMessageFound[] =
"Reserved key * found in message catalog.";
+const char kScriptBadgeRequiresFlag[] =
+ "The script_badge manifest key is turned off by default. "
+ "You can enable it with the --enable-script-badges command-line flag.";
+const char kScriptBadgeIconIgnored[] =
+ "default_icon specified in script_badge manifest section will not be used.";
const char kWebRequestConflictsWithLazyBackground[] =
"The 'webRequest' API cannot be used with event pages.";
#if defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698