Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc

Issue 10565017: Parse the script_badge manifest section. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Back out support for setting switches in unittests. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6
7 #include "chrome/common/extensions/extension_action.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/extension_switch_utils.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11 #include "testing/gmock/include/gmock/gmock.h"
12 #include "third_party/skia/include/core/SkBitmap.h"
13
14 namespace errors = extension_manifest_errors;
15 namespace switch_utils = extensions::switch_utils;
16 using extensions::Extension;
17
18 std::vector<Extension::InstallWarning> StripMissingFlagWarning(
19 const std::vector<Extension::InstallWarning>& install_warnings) {
20 std::vector<Extension::InstallWarning> result;
21 for (size_t i = 0; i < install_warnings.size(); ++i) {
22 if (install_warnings[i].message != errors::kScriptBadgeRequiresFlag)
23 result.push_back(install_warnings[i]);
24 }
25 return result;
26 }
27
28 TEST_F(ExtensionManifestTest, ScriptBadgeBasic) {
29 scoped_refptr<Extension> extension(
30 LoadAndExpectSuccess("script_badge_basic.json"));
31 ASSERT_TRUE(extension.get());
32 ASSERT_TRUE(extension->script_badge());
33 EXPECT_THAT(StripMissingFlagWarning(extension->install_warnings()),
34 testing::ElementsAre(/*empty*/));
35
36 EXPECT_EQ("Hello World", extension->script_badge()->GetTitle(
37 ExtensionAction::kDefaultTabId));
38 EXPECT_TRUE(extension->script_badge()->HasPopup(
39 ExtensionAction::kDefaultTabId));
40 EXPECT_TRUE(extension->script_badge()->GetIcon(
41 ExtensionAction::kDefaultTabId).isNull());
42 EXPECT_EQ("icon16.png", extension->script_badge()->default_icon_path());
43 }
44
45 TEST_F(ExtensionManifestTest, ScriptBadgeExplicitIconsIgnored) {
46 scoped_refptr<Extension> extension(
47 LoadAndExpectSuccess("script_badge_icons_ignored.json"));
48 ASSERT_TRUE(extension.get());
49 ASSERT_TRUE(extension->script_badge());
50
51 EXPECT_THAT(StripMissingFlagWarning(extension->install_warnings()),
52 testing::ElementsAre(
53 Extension::InstallWarning(
54 Extension::InstallWarning::FORMAT_TEXT,
55 errors::kScriptBadgeIconIgnored)));
56 EXPECT_TRUE(extension->script_badge()->GetIcon(
57 ExtensionAction::kDefaultTabId).isNull());
58 EXPECT_EQ("icon16.png", extension->script_badge()->default_icon_path());
59 }
60
61 TEST_F(ExtensionManifestTest, ScriptBadgeIconFallsBackToPuzzlePiece) {
62 scoped_refptr<Extension> extension(
63 LoadAndExpectSuccess("script_badge_only_use_icon16.json"));
64 ASSERT_TRUE(extension.get());
65 ASSERT_TRUE(extension->script_badge());
66 EXPECT_THAT(extension->install_warnings(),
67 testing::ElementsAre(/*empty*/));
68
69 EXPECT_EQ("", extension->script_badge()->default_icon_path())
70 << "Should not fall back to the 64px icon.";
71 EXPECT_FALSE(extension->script_badge()->GetIcon(
72 ExtensionAction::kDefaultTabId).isNull())
73 << "Should set the puzzle piece as the default, but there's no way "
74 << "to assert in a unittest what the image looks like.";
75 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698