chrome/test/data/extensions/manifest_tests/script_badge_basic.json - Issue 10565017: Parse the script_badge manifest section.

Side by Side Diff: chrome/test/data/extensions/manifest_tests/script_badge_basic.json

Issue 10565017: Parse the script_badge manifest section. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/extension_switch_utils.h ('K') | « chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc ('k') | chrome/test/data/extensions/manifest_tests/script_badge_icons_forbidden.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "manifest_version": 2,

	3 "name": "my extension",

	4 "version": "1.0.0.0",

	5 "description": "Check that a simple script_badge section parses",

	6 "icons": {

	7 "16": "icon16.png",

	8 "19": "icon19.png",
	Aaron Boodman 2012/06/16 01:50:38 Are you going to add support for the 19px size (th Are you going to add support for the 19px size (that would be cool). Jeffrey Yasskin 2012/06/18 22:16:03 I wasn't really planning to, since that increases Show quoted text On 2012/06/16 01:50:38, Aaron Boodman wrote: > Are you going to add support for the 19px size (that would be cool). I wasn't really planning to, since that increases the potential for hiding the script badge's identity. This test was actually checking that the code _doesn't_ use the 19px size. Still, if the extension chooses not to use the 16px badge for anything else, they could just as easily use that size to spoof another extension. We should find a general way to block this... Aaron Boodman 2012/06/18 23:17:35 I wrote this before you and I discussed in person. Show quoted text On 2012/06/18 22:16:03, Jeffrey Yasskin wrote: > On 2012/06/16 01:50:38, Aaron Boodman wrote: > > Are you going to add support for the 19px size (that would be cool). > > I wasn't really planning to, since that increases the potential for hiding the > script badge's identity. This test was actually checking that the code _doesn't_ > use the 19px size. > > Still, if the extension chooses not to use the 16px badge for anything else, > they could just as easily use that size to spoof another extension. We should > find a general way to block this... I wrote this before you and I discussed in person. I think what we ended up with is best path for now: 1) Use 16px icon from manifest if present 2) Fall back to puzzle piece We can ask the designers to design us a cute treatment for the 16px icon if necessary (depending on how this ends up looking). Jeffrey Yasskin 2012/06/18 23:58:41 Ah, ok. I'll use MATCH_EXACTLY instead. Show quoted text On 2012/06/18 23:17:35, Aaron Boodman wrote: > On 2012/06/18 22:16:03, Jeffrey Yasskin wrote: > > On 2012/06/16 01:50:38, Aaron Boodman wrote: > > > Are you going to add support for the 19px size (that would be cool). > > > > I wasn't really planning to, since that increases the potential for hiding the > > script badge's identity. This test was actually checking that the code > _doesn't_ > > use the 19px size. > > > > Still, if the extension chooses not to use the 16px badge for anything else, > > they could just as easily use that size to spoof another extension. We should > > find a general way to block this... > > I wrote this before you and I discussed in person. > > I think what we ended up with is best path for now: > > 1) Use 16px icon from manifest if present > 2) Fall back to puzzle piece Ah, ok. I'll use MATCH_EXACTLY instead. Show quoted text > We can ask the designers to design us a cute treatment for the 16px icon if > necessary (depending on how this ends up looking).
	9 "48": "icon48.png"

	10 },

	11 "script_badge": {

	12 "default_title": "Hello World",

	13 "default_popup": "popup.html"

	14 }

	15 }

OLD	NEW