Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 10565015: Add untrusted NaCl build for PPAPI proxy. (Closed)

Created:
8 years, 6 months ago by bbudge
Modified:
8 years, 6 months ago
Reviewers:
brettw, bradn
CC:
chromium-reviews, erikwright (departed), darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Add untrusted NaCl build for PPAPI proxy. This patch refactors ppapi_shared.gypi and ppapi_proxy.gypi into proper includes, adds ppapi_shared_untrusted and ppapi_proxy_untrusted .gyp files, and integrates them into the nacl_irt build (ppapi/native_client/native_client.gyp). In order to build without link errors, it includes our plugin side initialization of PluginDispatcher, and a PpapiPluginMain definition. When the 'build_ppapi_ipc_proxy_untrusted' gyp flag is set to '1', this will build a working NaCl IRT using the Chrome IPC proxy. BUG=116317 TEST=compiles, runs HelloWorld and GetURL SDK examples. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+944 lines, -926 lines) Patch
M base/base.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M base/base_untrusted.gyp View 2 chunks +1 line, -3 lines 0 comments Download
D base/rand_util_nacl.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M build/all.gyp View 4 chunks +14 lines, -5 lines 0 comments Download
M ipc/ipc_channel.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ipc/ipc_untrusted.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 3 chunks +162 lines, -1 line 0 comments Download
M ppapi/ppapi_internal.gyp View 1 chunk +61 lines, -0 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +194 lines, -172 lines 0 comments Download
M ppapi/ppapi_proxy_untrusted.gyp View 1 chunk +27 lines, -7 lines 0 comments Download
D ppapi/ppapi_proxy_untrusted.gypi View 1 chunk +0 lines, -416 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +296 lines, -259 lines 0 comments Download
A ppapi/ppapi_shared_untrusted.gyp View 1 chunk +35 lines, -0 lines 0 comments Download
M ppapi/proxy/DEPS View 1 chunk +5 lines, -1 line 0 comments Download
A ppapi/proxy/plugin_main_nacl.cc View 1 chunk +140 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bbudge
I had to revert the previous CL because it broke when disable_nacl==0. Changes only all.gyp
8 years, 6 months ago (2012-06-15 22:57:42 UTC) #1
brettw
lgtm
8 years, 6 months ago (2012-06-15 22:59:10 UTC) #2
bbudge
+bradn for his take. This was necessary to keep disable_nacl==1 folks building.
8 years, 6 months ago (2012-06-15 23:05:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/10565015/1
8 years, 6 months ago (2012-06-15 23:08:55 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-16 00:35:02 UTC) #5
Change committed as 142540

Powered by Google App Engine
This is Rietveld 408576698