repair disable_nacl=1

Repair disable_nacl=1 in base_untrusted.gyp

TBR=brettw@chromium.org

[scottmg, 2012-06-15 22:23:41]

(not sure if there's a better way to do this?)

[dmichael (off chromium), 2012-06-15 22:24:39]

I've used the same trick... LGTM
You can probably TBR brettw for OWNERS

[scottmg, 2012-06-15 22:26:20]

+brettw for OWNERS

[bbudge, 2012-06-15 22:26:40]

On 2012/06/15 22:24:39, dmichael wrote:
> I've used the same trick... LGTM
> You can probably TBR brettw for OWNERS

OK, but there are 4 new _untrusted.gyp files to patch.

[alexeypa (please no reviews), 2012-06-15 22:27:09]

It looks like other .gyp files from
https://chromiumcodereview.appspot.com/10546140 are affected as well.

[commit-bot: I haz the power, 2012-06-15 22:27:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/10565014/1

[scottmg, 2012-06-15 22:32:27]

On 2012/06/15 22:26:40, bbudge1 wrote:
> On 2012/06/15 22:24:39, dmichael wrote:
> > I've used the same trick... LGTM
> > You can probably TBR brettw for OWNERS
> 
> OK, but there are 4 new _untrusted.gyp files to patch.

Oops, thanks.

Looks a bit trickier, ppapi_proxy_untrusted is referenced in
chromium_builder_tests in all.gyp so just adding empty targets isn't enough.

[scottmg, 2012-06-15 22:36:55]

On 2012/06/15 22:32:27, scottmg wrote:
> On 2012/06/15 22:26:40, bbudge1 wrote:
> > On 2012/06/15 22:24:39, dmichael wrote:
> > > I've used the same trick... LGTM
> > > You can probably TBR brettw for OWNERS
> > 
> > OK, but there are 4 new _untrusted.gyp files to patch.
> 
> Oops, thanks.
> 
> Looks a bit trickier, ppapi_proxy_untrusted is referenced in
> chromium_builder_tests in all.gyp so just adding empty targets isn't enough.

A bit icky, but OK?

[bbudge, 2012-06-15 22:47:15]

There are 4 such files. When I try this trick, GYP starts complaining about
circular dependencies. I have another fix, which just puts the targets in
all.gyp in 'conditions'.

Thanks though!

[scottmg, 2012-06-15 23:03:31]

On 2012/06/15 22:47:15, bbudge1 wrote:
> There are 4 such files.

ppapi/native_client/native_client.gyp is the other one? But it's never included
unless disable_nacl==0.

> When I try this trick, GYP starts complaining about
> circular dependencies. I have another fix, which just puts the targets in
> all.gyp in 'conditions'.

OK, I thought I'd managed to generate (at least on Windows) with/without
disable_nacl=1.. but maybe I missed something.

You're going to post patch to make it work again?

[bradn, 2012-06-17 08:57:57]

LGTM