Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 10565012: Revert 142482 - Add untrusted NaCl build for PPAPI proxy. (Closed)

Created:
8 years, 6 months ago by bbudge
Modified:
8 years, 6 months ago
Reviewers:
bbudge
CC:
chromium-reviews, erikwright (departed), darin-cc_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 142482 - Add untrusted NaCl build for PPAPI proxy. This patch refactors ppapi_shared.gypi and ppapi_proxy.gypi into proper includes, adds ppapi_shared_untrusted and ppapi_proxy_untrusted .gyp files, and integrates them into the nacl_irt build (ppapi/native_client/native_client.gyp). In order to build without link errors, it includes our plugin side initialization of PluginDispatcher, and a PpapiPluginMain definition. When the 'build_ppapi_ipc_proxy_untrusted' gyp flag is set to '1', this will build a working NaCl IRT using the Chrome IPC proxy. BUG=116317 TEST=compiles, runs HelloWorld and GetURL SDK examples. Review URL: https://chromiumcodereview.appspot.com/10546140 TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -932 lines) Patch
M base/base.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M base/base_untrusted.gyp View 2 chunks +3 lines, -1 line 0 comments Download
A + base/rand_util_nacl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M build/all.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_channel.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ipc/ipc_untrusted.gyp View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/native_client/native_client.gyp View 3 chunks +1 line, -162 lines 0 comments Download
M ppapi/ppapi_internal.gyp View 2 chunks +1 line, -62 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +172 lines, -194 lines 0 comments Download
M ppapi/ppapi_proxy_untrusted.gyp View 1 chunk +7 lines, -27 lines 0 comments Download
A + ppapi/ppapi_proxy_untrusted.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +259 lines, -296 lines 0 comments Download
D ppapi/ppapi_shared_untrusted.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
M ppapi/proxy/DEPS View 1 chunk +1 line, -5 lines 0 comments Download
D ppapi/proxy/plugin_main_nacl.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bbudge
8 years, 6 months ago (2012-06-15 22:15:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698