Issue 10565006: Switch template_utils_unittest to using COMPILE_ASSERT.

Issue 10565006: Switch template_utils_unittest to using COMPILE_ASSERT. (Closed)

Created:
8 years, 6 months ago by gavinp

Modified:
8 years, 6 months ago

Reviewers:
Jeffrey Yasskin, willchan no longer on Chromium

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch template_utils_unittest to using COMPILE_ASSERT. This should be faster, and just as correct. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142998

Patch Set 2 : remediate to review #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -57 lines)			Patch
	M	base/template_util_unittest.cc	View	1	2 chunks	+52 lines, -57 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

Sorry, getting overwhelmed. Jeffrey, can you look at this for me instead?

8 years, 6 months ago (2012-06-18 20:04:10 UTC) #2

willchan no longer on Chromium

And I'll rubberstamp if it meets your approval.

8 years, 6 months ago (2012-06-18 20:04:26 UTC) #3

Jeffrey Yasskin

LGTM http://codereview.chromium.org/10565006/diff/1/base/template_util_unittest.cc File base/template_util_unittest.cc (right): http://codereview.chromium.org/10565006/diff/1/base/template_util_unittest.cc#newcode21 base/template_util_unittest.cc:21: Nit: I would skip the blank lines between ...

8 years, 6 months ago (2012-06-18 21:36:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10565006/12001

8 years, 6 months ago (2012-06-19 16:58:34 UTC) #6

Change committed as 142998

Expand Messages | Collapse Messages