Issue 10565002: Print correct line number for Error thrown inside eval.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10565002: Print correct line number for Error thrown inside eval. (Closed)

Created:
8 years, 6 months ago by Yang

Modified:
8 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Print correct line number for Error thrown inside eval. R=rossberg@chromium.org BUG=v8:1914 TEST=eval-stack-trace.js Committed: https://code.google.com/p/v8/source/detail?r=11851

Patch Set 3 : changed "unknown" to "<anonymous>" #

Total comments: 2

Patch Set 4 : Comment addressed #

Patch Set 5 : fix whitespace #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -12 lines)			Patch
	M	src/messages.js	View	1 2 3 4	2 chunks	+17 lines, -12 lines	0 comments	Download
	A	test/mjsunit/eval-stack-trace.js	View	1 2	1 chunk	+203 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

https://chromiumcodereview.appspot.com/10565002/diff/4/src/messages.js File src/messages.js (right): https://chromiumcodereview.appspot.com/10565002/diff/4/src/messages.js#newcode934 src/messages.js:934: if (!this.isNative()) { I think the code is clearer ...

8 years, 6 months ago (2012-06-18 13:11:30 UTC) #2

Yang

Please take another look. https://chromiumcodereview.appspot.com/10565002/diff/4/src/messages.js File src/messages.js (right): https://chromiumcodereview.appspot.com/10565002/diff/4/src/messages.js#newcode934 src/messages.js:934: if (!this.isNative()) { On 2012/06/18 ...

8 years, 6 months ago (2012-06-18 13:18:42 UTC) #3

lgtm