Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 10562033: Add a ScopedPPVar class for helping to track a reference to a base PP_Var. (Closed)

Created:
8 years, 6 months ago by brettw
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add a ScopedPPVar class for helping to track a reference to a base PP_Var. This will be used in unit tests and (possibly in the future) son proxy implementation code. This is basically copied from ScopedPPResource. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142982

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
M ppapi/ppapi_shared.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A ppapi/shared_impl/scoped_pp_var.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A ppapi/shared_impl/scoped_pp_var.cc View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
Not a high priority, should be easy. I'm cleaving off parts of my bigger change ...
8 years, 6 months ago (2012-06-18 04:16:47 UTC) #1
dmichael (off chromium)
http://codereview.chromium.org/10562033/diff/1/ppapi/shared_impl/scoped_pp_var.h File ppapi/shared_impl/scoped_pp_var.h (right): http://codereview.chromium.org/10562033/diff/1/ppapi/shared_impl/scoped_pp_var.h#newcode20 ppapi/shared_impl/scoped_pp_var.h:20: ScopedPPVar(const PP_Var& v); probably should be explicit? http://codereview.chromium.org/10562033/diff/1/ppapi/shared_impl/scoped_pp_var.h#newcode36 ppapi/shared_impl/scoped_pp_var.h:36: ...
8 years, 6 months ago (2012-06-18 20:09:16 UTC) #2
brettw
New snap up, PTAL
8 years, 6 months ago (2012-06-19 04:36:02 UTC) #3
dmichael (off chromium)
lgtm
8 years, 6 months ago (2012-06-19 14:34:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/10562033/8001
8 years, 6 months ago (2012-06-19 16:17:48 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 17:36:09 UTC) #6
Change committed as 142982

Powered by Google App Engine
This is Rietveld 408576698