Chek stack overflow in while an do-while node (in order to be able to interrupt loops).

runtime/vm/flow_graph_builder.cc

Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc	(revision 8724)
+++ runtime/vm/flow_graph_builder.cc	(working copy)
@@ -1074,6 +1074,11 @@
 
   EffectGraphVisitor for_body(owner(), temp_index());
   node->body()->Visit(&for_body);
+  if (for_body.is_open()) {
+    CheckStackOverflowComp* comp =
+        new CheckStackOverflowComp(node->token_index(), owner()->try_index());
+    for_body.AddInstruction(new DoInstr(comp));
+  }

[Vyacheslav Egorov (Google), 2012/06/15 17:43:02]

I am not sure that this is enough for the case like:

while (true) {
  if (true) {
    continue;
  }
}

Easiest way seems to prepend check to the body (insert it as a first
instruction) not append it.

I think similar control flow can affect both DoWhileNode and ForNode.

[srdjan, 2012/06/15 17:56:10]

Done.

 
   // Labels are set after body traversal.
   SourceLabel* lbl = node->label();
@@ -1100,6 +1105,11 @@
   // Traverse body first in order to generate continue and break labels.
   EffectGraphVisitor for_body(owner(), temp_index());
   node->body()->Visit(&for_body);
+  if (for_body.is_open()) {
+    CheckStackOverflowComp* comp =
+        new CheckStackOverflowComp(node->token_index(), owner()->try_index());
+    for_body.AddInstruction(new DoInstr(comp));
+  }
 
   TestGraphVisitor for_test(owner(),
                             temp_index(),