Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(174)

Issue 10562007: Added files for audio readers. (Closed)

Created:
8 years, 3 months ago by kxing
Modified:
8 years, 3 months ago
Reviewers:
Sergey Ulanov, Wez, garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Added files for audio readers. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142497

Patch Set 1 #

Patch Set 2 : Fixed some style issues #

Patch Set 3 : Squashed ProtobufAudioReader into AudioReader #

Total comments: 8

Patch Set 4 : Fixed style nits #

Total comments: 6

Patch Set 5 : Addressed comments #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -0 lines) Patch
A remoting/protocol/audio_reader.h View 1 2 3 4 1 chunk +67 lines, -0 lines 6 comments Download
A remoting/protocol/audio_reader.cc View 1 2 3 4 1 chunk +68 lines, -0 lines 2 comments Download
M remoting/remoting.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kxing
Please let me know if you think we should merge ProtobufAudioReader into AudioReader.
8 years, 3 months ago (2012-06-15 15:37:01 UTC) #1
Sergey Ulanov
On 2012/06/15 15:37:01, kxing wrote: > Please let me know if you think we should ...
8 years, 3 months ago (2012-06-15 17:48:15 UTC) #2
kxing
(new patch)
8 years, 3 months ago (2012-06-15 18:46:08 UTC) #3
Sergey Ulanov
some style nits http://codereview.chromium.org/10562007/diff/6001/remoting/protocol/audio_reader.h File remoting/protocol/audio_reader.h (right): http://codereview.chromium.org/10562007/diff/6001/remoting/protocol/audio_reader.h#newcode26 remoting/protocol/audio_reader.h:26: static AudioReader* Create(const SessionConfig& config); this ...
8 years, 3 months ago (2012-06-15 19:35:23 UTC) #4
kxing
http://codereview.chromium.org/10562007/diff/6001/remoting/protocol/audio_reader.h File remoting/protocol/audio_reader.h (right): http://codereview.chromium.org/10562007/diff/6001/remoting/protocol/audio_reader.h#newcode26 remoting/protocol/audio_reader.h:26: static AudioReader* Create(const SessionConfig& config); On 2012/06/15 19:35:23, sergeyu ...
8 years, 3 months ago (2012-06-15 19:46:41 UTC) #5
Sergey Ulanov
http://codereview.chromium.org/10562007/diff/6002/remoting/protocol/audio_reader.h File remoting/protocol/audio_reader.h (right): http://codereview.chromium.org/10562007/diff/6002/remoting/protocol/audio_reader.h#newcode30 remoting/protocol/audio_reader.h:30: explicit AudioReader(AudioPacket::Encoding encoding); Since this is called from Create, ...
8 years, 3 months ago (2012-06-15 19:54:41 UTC) #6
kxing
http://codereview.chromium.org/10562007/diff/6002/remoting/protocol/audio_reader.h File remoting/protocol/audio_reader.h (right): http://codereview.chromium.org/10562007/diff/6002/remoting/protocol/audio_reader.h#newcode30 remoting/protocol/audio_reader.h:30: explicit AudioReader(AudioPacket::Encoding encoding); On 2012/06/15 19:54:41, sergeyu wrote: > ...
8 years, 3 months ago (2012-06-15 20:03:06 UTC) #7
kxing
For the scoped_ptr issue, should we also refactor the VideoReader and VideoWriter Create() methods as ...
8 years, 3 months ago (2012-06-15 20:06:52 UTC) #8
Sergey Ulanov
LGTM. On 2012/06/15 20:06:52, kxing wrote: > For the scoped_ptr issue, should we also refactor ...
8 years, 3 months ago (2012-06-15 20:10:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kxing@chromium.org/10562007/12001
8 years, 3 months ago (2012-06-15 20:17:07 UTC) #10
kxing
The cleanup CL can be found at http://codereview.chromium.org/10556020/
8 years, 3 months ago (2012-06-15 20:38:01 UTC) #11
Wez
http://codereview.chromium.org/10562007/diff/12001/remoting/protocol/audio_reader.cc File remoting/protocol/audio_reader.cc (right): http://codereview.chromium.org/10562007/diff/12001/remoting/protocol/audio_reader.cc#newcode30 remoting/protocol/audio_reader.cc:30: return scoped_ptr<AudioReader>(new AudioReader(AudioPacket::ENCODING_RAW)); This limits you to using a ...
8 years, 3 months ago (2012-06-15 20:40:54 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-06-15 22:21:42 UTC) #13
Change committed as 142497

Powered by Google App Engine
This is Rietveld 408576698