Consolidate RecordBrowserStartupTime() into one location

base/process_info_mac.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/process_info.h"
+
+#include <sys/sysctl.h>
+#include <sys/time.h>
+#include <unistd.h>
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/time.h"
+
+namespace {
+
+using base::Time;
+
+// Returns the process creation time, or a null time object if an error
+// occurred.
+Time ProcessCreationTimeInternal() {
+  int mib[] = { CTL_KERN, KERN_PROC, KERN_PROC_PID, getpid() };
+  size_t len = 0;
+  if (sysctl(mib, arraysize(mib), NULL, &len, NULL, 0) < 0)
+    return Time();
+
+  scoped_ptr_malloc<struct kinfo_proc>
+      proc(static_cast<struct kinfo_proc*>(malloc(len)));
+  if (sysctl(mib, arraysize(mib), proc.get(), &len, NULL, 0) < 0)
+    return Time();
+  return Time::FromTimeVal(proc->kp_proc.p_un.__p_starttime);
+}
+
+}  // namespace
+
+namespace base {
+
+//static
+const Time* CurrentProcessInfo::CreationTime() {
+  static Time process_creation_time = ProcessCreationTimeInternal();

[Mark Mentovai, 2012/06/19 16:08:00]

Did “new Time()” and using the Time* interface to the internal function not
work?

This (pointerless interface) leaves open the possibility of the static
destructor. That’s no good.

It also doesn’t match the documented behavior of returning NULL on error. It
instead returns Time(0). NULL is better.

+  return &process_creation_time;
+}
+
+}  // namespace base