Mac printing: Autorotate printed pages so their orientation is the same as the destination page.

Mac printing: Autorotate printed pages so their orientation is the same as the destination page.

BUG=93303, 132922
TEST=manual
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142824

[kmadhusu, 2012-06-16 00:44:11]

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/metafile.h
File printing/metafile.h (right):

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/metafile.h#ne...
printing/metafile.h:142: bool autorotate) const = 0;
Looks like we are adding more fit to page params to this function. Can you
create a struct with all these bool params as member variables?

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/pdf_metafile_...
File printing/pdf_metafile_cg_mac.cc (right):

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/pdf_metafile_...
printing/pdf_metafile_cg_mac.cc:230: CGContextTranslateCTM(context, x_offset,
y_offset);
Why can't we do a single Translation operation like before?

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/pdf_metafile_...
printing/pdf_metafile_cg_mac.cc:232: CGContextTranslateCTM(context,
rect.size.width, 0);
Can you add a comment on why we need to do this translation?

[Lei Zhang, 2012-06-16 01:47:20]

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/metafile.h
File printing/metafile.h (right):

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/metafile.h#ne...
printing/metafile.h:142: bool autorotate) const = 0;
On 2012/06/16 00:44:11, kmadhusu wrote:
> Looks like we are adding more fit to page params to this function. Can you
> create a struct with all these bool params as member variables?

Done.

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/pdf_metafile_...
File printing/pdf_metafile_cg_mac.cc (right):

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/pdf_metafile_...
printing/pdf_metafile_cg_mac.cc:230: CGContextTranslateCTM(context, x_offset,
y_offset);
On 2012/06/16 00:44:11, kmadhusu wrote:
> Why can't we do a single Translation operation like before?

We may be able to, but it's easier to visualize what is happening when you break
the translation into distinct steps:

- adjust for the offset
- adjust for the rotation
- adjust for centering

https://chromiumcodereview.appspot.com/10560021/diff/1/printing/pdf_metafile_...
printing/pdf_metafile_cg_mac.cc:232: CGContextTranslateCTM(context,
rect.size.width, 0);
On 2012/06/16 00:44:11, kmadhusu wrote:
> Can you add a comment on why we need to do this translation?

Done.

[kmadhusu, 2012-06-17 20:18:28]

LGTM with changes.

https://chromiumcodereview.appspot.com/10560021/diff/2002/printing/metafile.h
File printing/metafile.h (right):

https://chromiumcodereview.appspot.com/10560021/diff/2002/printing/metafile.h...
printing/metafile.h:57: bool shrink_to_fit;
Can you write a default constructor which initializes all these member variables
to false?  Instances can overwrite the ones that need to be set to true.

[Lei Zhang, 2012-06-18 20:58:25]

https://chromiumcodereview.appspot.com/10560021/diff/2002/printing/metafile.h
File printing/metafile.h (right):

https://chromiumcodereview.appspot.com/10560021/diff/2002/printing/metafile.h...
printing/metafile.h:57: bool shrink_to_fit;
On 2012/06/17 20:18:28, kmadhusu wrote:
> Can you write a default constructor which initializes all these member
variables
> to false?  Instances can overwrite the ones that need to be set to true. 

Done.