Issue 10560014: Aura desktop: Fix tab dragging within a single chrome window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10560014: Aura desktop: Fix tab dragging within a single chrome window. (Closed)

Created:
8 years, 6 months ago by Elliot Glaysher

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Aura desktop: Fix tab dragging within a single chrome window. Tabs can now be reordered inside a single chrome window on linux_aura. Multiselection works too. Dragging out of a window doesn't work yet. Most of dock_info_aura.cc has been copied from dock_info_gtk.cc. A helper function was moved from gtk_util to x11_util (which only used pure X functions.) BUG=133059 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142568

Patch Set 1 #

Patch Set 2 : Fix filename so windows is excluded. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -95 lines)			Patch
M	chrome/browser/fullscreen_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/screensaver_window_finder_gtk.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/aura/tabs/dock_info_aura.cc	View	1	1 chunk	+0 lines, -38 lines	0 comments	Download
A +	chrome/browser/ui/aura/tabs/dock_info_aurax11.cc	View	1	8 chunks	+40 lines, -29 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.cc	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/ui/gtk/tabs/dock_info_gtk.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/root_window.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura/root_window.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	ui/base/x/x11_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/base/x/x11_util.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_helper_aura.cc	View		4 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10560014/3003

8 years, 6 months ago (2012-06-16 00:12:02 UTC) #3

Change committed as 142568

Expand Messages | Collapse Messages