Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3140)

Unified Diff: base/win/win_util.cc

Issue 10559097: Replace all spaces by '_' in the AppUserModelId (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/util/shell_util.cc » ('j') | chrome/installer/util/shell_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/win_util.cc
diff --git a/base/win/win_util.cc b/base/win/win_util.cc
index 96507d55606bff674d69b34ba8bc98e33e4f7c42..2f2e7dc76214ca9ad8b4b2fae993f2688b1cb649 100644
--- a/base/win/win_util.cc
+++ b/base/win/win_util.cc
@@ -180,10 +180,10 @@ bool SetStringValueForPropertyStore(IPropertyStore* property_store,
bool SetAppIdForPropertyStore(IPropertyStore* property_store,
const wchar_t* app_id) {
- // App id should be less than 128 chars and contain no space. And recommended
+ // App id should be less than 64 chars and contain no space. And recommended
robertshield 2012/06/20 21:50:16 this does not look to be part of the CL descriptio
gab 2012/06/20 21:58:36 Done.
// format is CompanyName.ProductName[.SubProduct.ProductNumber].
// See http://msdn.microsoft.com/en-us/library/dd378459%28VS.85%29.aspx
- DCHECK(lstrlen(app_id) < 128 && wcschr(app_id, L' ') == NULL);
+ DCHECK(lstrlen(app_id) < 64 && wcschr(app_id, L' ') == NULL);
return SetStringValueForPropertyStore(property_store,
PKEY_AppUserModel_ID,
« no previous file with comments | « no previous file | chrome/installer/util/shell_util.cc » ('j') | chrome/installer/util/shell_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698