Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 10559086: Fixing mime type so that MHTML files can be opened directly from Google Drive. (Closed)

Created:
8 years, 6 months ago by tudalex(Chromium)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fixing mime type so that MHTML files can be opened directly from Google Drive. BUG=126955 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143253

Patch Set 1 #

Total comments: 6

Patch Set 2 : Open MHTML directly from gdrive #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/chromeos/gdata/gdata_protocol_handler.cc View 1 2 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tudalex(Chromium)
8 years, 6 months ago (2012-06-20 16:29:38 UTC) #1
Greg Spencer (Chromium)
Just some style comments. http://codereview.chromium.org/10559086/diff/1/chrome/browser/chromeos/gdata/gdata_protocol_handler.cc File chrome/browser/chromeos/gdata/gdata_protocol_handler.cc (right): http://codereview.chromium.org/10559086/diff/1/chrome/browser/chromeos/gdata/gdata_protocol_handler.cc#newcode326 chrome/browser/chromeos/gdata/gdata_protocol_handler.cc:326: const struct MimeTypeReplacement { Can ...
8 years, 6 months ago (2012-06-20 16:44:56 UTC) #2
tudalex(Chromium)
http://codereview.chromium.org/10559086/diff/1/chrome/browser/chromeos/gdata/gdata_protocol_handler.cc File chrome/browser/chromeos/gdata/gdata_protocol_handler.cc (right): http://codereview.chromium.org/10559086/diff/1/chrome/browser/chromeos/gdata/gdata_protocol_handler.cc#newcode326 chrome/browser/chromeos/gdata/gdata_protocol_handler.cc:326: const struct MimeTypeReplacement { On 2012/06/20 16:44:56, Greg Spencer ...
8 years, 6 months ago (2012-06-20 18:20:30 UTC) #3
Greg Spencer (Chromium)
LGTM from my point of view. Tony, Alex needs an OWNERS review for this.
8 years, 6 months ago (2012-06-20 18:29:24 UTC) #4
tbarzic
On 2012/06/20 18:29:24, Greg Spencer (Chromium) wrote: > LGTM from my point of view. > ...
8 years, 6 months ago (2012-06-20 18:32:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tudalex@chromium.org/10559086/6001
8 years, 6 months ago (2012-06-20 18:46:38 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-20 20:44:23 UTC) #7
Change committed as 143253

Powered by Google App Engine
This is Rietveld 408576698