Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 10559083: Fix GC bug with missing handle. Bug=133618 (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2309 matching lines...) Expand 10 before | Expand all | Expand 10 after
2320 // Non-negative property indices are in the properties array. 2320 // Non-negative property indices are in the properties array.
2321 __ mov(result, FieldOperand(object, JSObject::kPropertiesOffset)); 2321 __ mov(result, FieldOperand(object, JSObject::kPropertiesOffset));
2322 __ mov(result, FieldOperand(result, offset + FixedArray::kHeaderSize)); 2322 __ mov(result, FieldOperand(result, offset + FixedArray::kHeaderSize));
2323 } 2323 }
2324 } else if (lookup.IsFound() && lookup.type() == CONSTANT_FUNCTION) { 2324 } else if (lookup.IsFound() && lookup.type() == CONSTANT_FUNCTION) {
2325 Handle<JSFunction> function(lookup.GetConstantFunctionFromMap(*type)); 2325 Handle<JSFunction> function(lookup.GetConstantFunctionFromMap(*type));
2326 __ LoadHeapObject(result, function); 2326 __ LoadHeapObject(result, function);
2327 } else { 2327 } else {
2328 // Negative lookup. 2328 // Negative lookup.
2329 // Check prototypes. 2329 // Check prototypes.
2330 HeapObject* current = HeapObject::cast((*type)->prototype()); 2330 Handle<HeapObject> current(HeapObject::cast((*type)->prototype()));
2331 Heap* heap = type->GetHeap(); 2331 Heap* heap = type->GetHeap();
2332 while (current != heap->null_value()) { 2332 while (*current != heap->null_value()) {
2333 Handle<HeapObject> link(current); 2333 __ LoadHeapObject(result, current);
2334 __ LoadHeapObject(result, link);
2335 __ cmp(FieldOperand(result, HeapObject::kMapOffset), 2334 __ cmp(FieldOperand(result, HeapObject::kMapOffset),
2336 Handle<Map>(JSObject::cast(current)->map())); 2335 Handle<Map>(current->map()));
2337 DeoptimizeIf(not_equal, env); 2336 DeoptimizeIf(not_equal, env);
2338 current = HeapObject::cast(current->map()->prototype()); 2337 current =
2338 Handle<HeapObject>(HeapObject::cast(current->map()->prototype()));
2339 } 2339 }
2340 __ mov(result, factory()->undefined_value()); 2340 __ mov(result, factory()->undefined_value());
2341 } 2341 }
2342 } 2342 }
2343 2343
2344 2344
2345 void LCodeGen::EmitPushTaggedOperand(LOperand* operand) { 2345 void LCodeGen::EmitPushTaggedOperand(LOperand* operand) {
2346 ASSERT(!operand->IsDoubleRegister()); 2346 ASSERT(!operand->IsDoubleRegister());
2347 if (operand->IsConstantOperand()) { 2347 if (operand->IsConstantOperand()) {
2348 Handle<Object> object = ToHandle(LConstantOperand::cast(operand)); 2348 Handle<Object> object = ToHandle(LConstantOperand::cast(operand));
(...skipping 2880 matching lines...) Expand 10 before | Expand all | Expand 10 after
5229 FixedArray::kHeaderSize - kPointerSize)); 5229 FixedArray::kHeaderSize - kPointerSize));
5230 __ bind(&done); 5230 __ bind(&done);
5231 } 5231 }
5232 5232
5233 5233
5234 #undef __ 5234 #undef __
5235 5235
5236 } } // namespace v8::internal 5236 } } // namespace v8::internal
5237 5237
5238 #endif // V8_TARGET_ARCH_IA32 5238 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698