Give up on verifying stdout for most git gclient scm tests.

Give up on verifying stdout for most git gclient scm tests.

The output is dependent on git's version. This is blocking the CQ.

TBR=petermayo@chromium.org
BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143172

[commit-bot: I haz the power, 2012-06-20 01:56:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10559075/1

[commit-bot: I haz the power, 2012-06-20 01:58:25]

Presubmit check for 10559075-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
Failed to checkout rietveld. Do you have mercurial installed?
[Errno 2] No such file or directory

Presubmit checks took 127.2s to calculate.

[commit-bot: I haz the power, 2012-06-20 02:12:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10559075/1

[commit-bot: I haz the power, 2012-06-20 02:14:51]

Presubmit check for 10559075-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
push-basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
Branch work set up to track remote branch master from origin.
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl status now knows the issue
/b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh: line 41: curl:
command not found


basic.sh failed
Command /b/commit-queue/workdir/tools/depot_tools/tests/basic.sh returned
non-zero exit status 1 in /b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl status now knows the issue
/b/commit-queue/workdir/tools/depot_tools/tests/basic.sh: line 42: curl: command
not found


Presubmit checks took 158.5s to calculate.

[Peter Mayo, 2012-06-20 14:25:17]

And why keep all of the dead code?  It's in SCM.

If you're going to keep the output of the commands, you could just copy them
verbatim.

https://chromiumcodereview.appspot.com/10559075/diff/1/tests/gclient_scm_test.py
File tests/gclient_scm_test.py (right):

https://chromiumcodereview.appspot.com/10559075/diff/1/tests/gclient_scm_test...
tests/gclient_scm_test.py:824: sys.stdout.close()
Why does this object need to be closed all of the time?

https://chromiumcodereview.appspot.com/10559075/diff/1/tests/gclient_scm_test...
tests/gclient_scm_test.py:1057: start = ('\n________ running \'git commit -am
test\' in \'%s\'\n'
This doesn't seem that useful, why did it get spared?

[M-A Ruel, 2012-06-20 14:32:02]

cleaned up

https://chromiumcodereview.appspot.com/10559075/diff/1/tests/gclient_scm_test.py
File tests/gclient_scm_test.py (right):

https://chromiumcodereview.appspot.com/10559075/diff/1/tests/gclient_scm_test...
tests/gclient_scm_test.py:824: sys.stdout.close()
On 2012/06/20 14:25:17, Peter Mayo wrote:
> Why does this object need to be closed all of the time?

It's a mock and tearDown() verifies that no stray output is left in it.

https://chromiumcodereview.appspot.com/10559075/diff/1/tests/gclient_scm_test...
tests/gclient_scm_test.py:1057: start = ('\n________ running \'git commit -am
test\' in \'%s\'\n'
On 2012/06/20 14:25:17, Peter Mayo wrote:
> This doesn't seem that useful, why did it get spared?

Removed it all.

[Peter Mayo, 2012-06-20 14:38:08]

lgtm

[Peter Mayo, 2012-06-20 14:38:08]

lgtm

lgtm

[commit-bot: I haz the power, 2012-06-20 14:43:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10559075/3

[commit-bot: I haz the power, 2012-06-20 14:46:04]

Change committed as 143172