Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 10559071: Exit mouse lock or fullscreen on navigation and reload. (Closed)

Created:
8 years, 6 months ago by scheib
Modified:
8 years, 6 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, koz (OOO until 15th September), jeremya
Visibility:
Public.

Description

Exit mouse lock or fullscreen on navigation and reload. BUG=131702, 132669, 130301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143417

Patch Set 1 #

Total comments: 11

Patch Set 2 : feedback addressed. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -39 lines) Patch
M chrome/browser/ui/fullscreen_controller.h View 1 3 chunks +6 lines, -9 lines 1 comment Download
M chrome/browser/ui/fullscreen_controller.cc View 1 11 chunks +33 lines, -28 lines 1 comment Download
M chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc View 1 1 chunk +152 lines, -0 lines 0 comments Download
M chrome/browser/ui/fullscreen_controller_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/fullscreen_controller_test.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scheib
(fyi for jeremya, koz)
8 years, 6 months ago (2012-06-19 23:06:26 UTC) #1
scheib
FYI: This change fixes a crash when mouse lock is pending -- and should be ...
8 years, 6 months ago (2012-06-19 23:08:57 UTC) #2
koz (OOO until 15th September)
lgtm This is a much nicer solution, cheers! https://chromiumcodereview.appspot.com/10559071/diff/1/chrome/browser/ui/fullscreen_controller.cc File chrome/browser/ui/fullscreen_controller.cc (right): https://chromiumcodereview.appspot.com/10559071/diff/1/chrome/browser/ui/fullscreen_controller.cc#newcode571 chrome/browser/ui/fullscreen_controller.cc:571: void ...
8 years, 6 months ago (2012-06-19 23:57:17 UTC) #3
jeremya
I'm not an expert on the fullscreen controller stuff any more, but this looks like ...
8 years, 6 months ago (2012-06-20 15:36:34 UTC) #4
yzshen1
LGTM with a few nits. https://chromiumcodereview.appspot.com/10559071/diff/1/chrome/browser/ui/fullscreen_controller.cc File chrome/browser/ui/fullscreen_controller.cc (right): https://chromiumcodereview.appspot.com/10559071/diff/1/chrome/browser/ui/fullscreen_controller.cc#newcode390 chrome/browser/ui/fullscreen_controller.cc:390: DCHECK(fullscreened_tab_ == mouse_lock_tab_); nit: ...
8 years, 6 months ago (2012-06-20 18:07:54 UTC) #5
scheib
sky, owners review please. https://chromiumcodereview.appspot.com/10559071/diff/1/chrome/browser/ui/fullscreen_controller.cc File chrome/browser/ui/fullscreen_controller.cc (right): https://chromiumcodereview.appspot.com/10559071/diff/1/chrome/browser/ui/fullscreen_controller.cc#newcode390 chrome/browser/ui/fullscreen_controller.cc:390: DCHECK(fullscreened_tab_ == mouse_lock_tab_); On 2012/06/20 ...
8 years, 6 months ago (2012-06-20 20:38:24 UTC) #6
yzshen1
lgtm https://chromiumcodereview.appspot.com/10559071/diff/1/chrome/browser/ui/fullscreen_controller.cc File chrome/browser/ui/fullscreen_controller.cc (right): https://chromiumcodereview.appspot.com/10559071/diff/1/chrome/browser/ui/fullscreen_controller.cc#newcode390 chrome/browser/ui/fullscreen_controller.cc:390: DCHECK(fullscreened_tab_ == mouse_lock_tab_); A if-block containing only a ...
8 years, 6 months ago (2012-06-20 20:56:46 UTC) #7
scheib
sky, sorry to bump this up again, but it will fix crashes and should merge ...
8 years, 6 months ago (2012-06-21 17:16:57 UTC) #8
scheib
sky, owners review please. (doh! I failed to add sky earlier)
8 years, 6 months ago (2012-06-21 17:23:08 UTC) #9
sky
8 years, 6 months ago (2012-06-21 18:07:22 UTC) #10
LGTM
What do you guys think of creating a fullscreen directory and moving this code
there? That way you and koz could be owners.

http://codereview.chromium.org/10559071/diff/6002/chrome/browser/ui/fullscree...
File chrome/browser/ui/fullscreen_controller.cc (right):

http://codereview.chromium.org/10559071/diff/6002/chrome/browser/ui/fullscree...
chrome/browser/ui/fullscreen_controller.cc:400: DCHECK(fullscreened_tab_ ==
mouse_lock_tab_);
This makes me mildly nervous because its a single line if with the contents a
DCHECK, which is compiled out in release builds. Could you add {} here? Also,
use DCHECK_EQ

http://codereview.chromium.org/10559071/diff/6002/chrome/browser/ui/fullscree...
File chrome/browser/ui/fullscreen_controller.h (right):

http://codereview.chromium.org/10559071/diff/6002/chrome/browser/ui/fullscree...
chrome/browser/ui/fullscreen_controller.h:122: void
UpdateNotificationRegistrations();
Add a description.

Powered by Google App Engine
This is Rietveld 408576698