chrome/browser/extensions/extension_prefs.cc - Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Wrote test Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_preference_apitest.cc ('K') | « chrome/browser/extensions/extension_prefs.h ('k') | chrome/browser/prefs/pref_notifier_impl.cc » ('j') | chrome/test/data/extensions/api_test/preference/onchange_split/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_prefs.cc

diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc

index fc523325778fb2595eb0f3e26bdcf5ca556db153..442f2f443b0c8ecfe65fe545bd2d93ed47ff289a 100644

--- a/chrome/browser/extensions/extension_prefs.cc

+++ b/chrome/browser/extensions/extension_prefs.cc

@@ -1863,14 +1863,14 @@ bool ExtensionPrefs::CanExtensionControlPref(const std::string& extension_id,

bool ExtensionPrefs::DoesExtensionControlPref(const std::string& extension_id,

const std::string& pref_key,

- bool incognito) {

+ bool* from_incognito) {

DCHECK(pref_service()->FindPreference(pref_key.c_str()))

<< "Extension controlled preference key " << pref_key

<< " not registered.";

return extension_pref_value_map_->DoesExtensionControlPref(extension_id,

pref_key,

- incognito);

+ from_incognito);

}

bool ExtensionPrefs::HasIncognitoPrefValue(const std::string& pref_key) {