chrome/browser/extensions/extension_event_router.cc - Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_event_router.cc

Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Wrote test Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_event_router.cc

diff --git a/chrome/browser/extensions/extension_event_router.cc b/chrome/browser/extensions/extension_event_router.cc

index c3b680d889a32b2699f325a034d11e40f46ed09b..edd8e2323964e0b8f5c0a7d1710bf84c578ca97a 100644

--- a/chrome/browser/extensions/extension_event_router.cc

+++ b/chrome/browser/extensions/extension_event_router.cc

@@ -429,8 +429,9 @@ void ExtensionEventRouter::DispatchEventToProcess(

const Value* event_args = NULL;

if (!CanDispatchEventToProfile(listener_profile, extension,

- event, &event_args))

+ event, &event_args)) {

return;

+ }

DispatchEvent(process, extension_id,

event->event_name, *event_args,

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_pref_value_map.h » ('j') | chrome/browser/extensions/extension_preference_apitest.cc » ('J')