chrome/test/data/extensions/api_test/preference/onchange/manifest.json - Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/preference/onchange/manifest.json

Issue 10559052: Split mode incognito extension can get misleading pref changed events from regular mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Deleted commented-out lines in extension_preference_api.cc Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prefs/pref_notifier_impl.cc ('k') | chrome/test/data/extensions/api_test/preference/onchange/test.html » ('j') | chrome/test/data/extensions/api_test/preference/onchange/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/preference/onchange/manifest.json

diff --git a/chrome/test/data/extensions/api_test/preference/onchange/manifest.json b/chrome/test/data/extensions/api_test/preference/onchange/manifest.json

index 7c8641fcb140dc17f0e8da9ab222ead73ab0df59..2c70e7a0afbea539fc533ac18083cf8eb3cfeba9 100644

--- a/chrome/test/data/extensions/api_test/preference/onchange/manifest.json

+++ b/chrome/test/data/extensions/api_test/preference/onchange/manifest.json

@@ -3,8 +3,8 @@

"version" : "0.1",

"manifest_version": 2,

"description" : "Preferences API Test Extension (Events)",

- "permissions": [ "privacy" ],

+ "permissions": [ "privacy", "tabs" ],

"background": {

- "page": "test.html"

+ "scripts": [ "test.js" ]

}