Split mode incognito extension can get misleading pref changed events from regular mode

chrome/browser/extensions/extension_preference_helpers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_preference_helpers.h"
 
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_event_router.h"
 #include "chrome/browser/extensions/extension_prefs.h"
@@ skipping 62 matching lines @@
     const std::string& event_name,
     ListValue* args,
     ExtensionAPIPermission::ID permission,
     bool incognito,
     const std::string& browser_pref) {
   ExtensionEventRouter* router = profile->GetExtensionEventRouter();
   if (!router || !router->HasEventListener(event_name))
     return;
   ExtensionService* extension_service = profile->GetExtensionService();
   const ExtensionSet* extensions = extension_service->extensions();
+  ExtensionPrefs* extension_prefs = extension_service->extension_prefs();
   for (ExtensionSet::const_iterator it = extensions->begin();
        it != extensions->end(); ++it) {
     std::string extension_id = (*it)->id();
     // TODO(bauerb): Only iterate over registered event listeners.
     if (router->ExtensionHasEventListener(extension_id, event_name) &&
         (*it)->HasAPIPermission(permission) &&
-        (!incognito || extension_service->CanCrossIncognito(*it))) {
+        (!incognito || (*it)->incognito_split_mode() ||
+          extension_service->CanCrossIncognito(*it))) {

[Bernhard Bauer, 2012/06/19 01:12:56]

Nit: I think this needs to be indented by one less space (it should be aligned
with the expresion above, which starts with the "!").

[mitchellwrosen, 2012/06/20 18:28:26]

Done.

       // Inject level of control key-value.
       DictionaryValue* dict;
       bool rv = args->GetDictionary(0, &dict);
       DCHECK(rv);
       std::string level_of_control =
           GetLevelOfControl(profile, extension_id, browser_pref, incognito);
       dict->SetString(kLevelOfControlKey, level_of_control);
-
       std::string json_args;
       base::JSONWriter::Write(args, &json_args);
+
+      // If the extension is in incognito split mode,
+      // a) incognito pref changes are visible only to the incognito tabs
+      // b) regular pref chanes are visible only to the incognito tabs if the

[Bernhard Bauer, 2012/06/19 01:12:56]

Nit: "pref changes"

[mitchellwrosen, 2012/06/20 18:28:26]

Done.

+      //    incognito pref has not alredy been set
+      Profile* restrict_to_profile = NULL;
+      if ((*it)->incognito_split_mode()) {
+        if (incognito && extension_service->IsIncognitoEnabled(extension_id)) {
+          restrict_to_profile = profile->GetOffTheRecordProfile();
+        } else if (!incognito &&
+                   extension_prefs->DoesExtensionControlIncognitoPref(
+                       extension_id,
+                       browser_pref)) {
+          restrict_to_profile = profile;
+        }
+      }
+
       router->DispatchEventToExtension(
-          extension_id, event_name, json_args, NULL, GURL());
+          extension_id, event_name, json_args, restrict_to_profile, GURL());
     }
   }
 }
 
 }  // namespace extension_preference_helpers