Issue 10559050: sync: rename OnDisableDatatype to DisableBrokenDatatype.

Issue 10559050: sync: rename OnDisableDatatype to DisableBrokenDatatype. (Closed)

Created:
8 years, 6 months ago by tim (not reviewing)

Modified:
8 years, 6 months ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Nicolas Zea

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sync: rename OnDisableDatatype to DisableBrokenDatatype. "On" is typically reserved for api callbacks, and 'disable datatype' is a conflated term. BUG=132020 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142840

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 2

Patch Set 3 : review #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -16 lines)			Patch
M	chrome/browser/sync/glue/app_notification_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/frontend_data_type_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/non_frontend_data_type_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/search_engine_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/theme_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/typed_url_data_type_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/ui_data_type_controller.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/ui_data_type_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/ui_data_type_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_mock.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

Based off of http://codereview.chromium.org/10553042/

8 years, 6 months ago (2012-06-18 22:13:02 UTC) #1

akalin

LGTM http://codereview.chromium.org/10559050/diff/6001/chrome/browser/sync/profile_sync_service.h File chrome/browser/sync/profile_sync_service.h (right): http://codereview.chromium.org/10559050/diff/6001/chrome/browser/sync/profile_sync_service.h#newcode354 chrome/browser/sync/profile_sync_service.h:354: virtual void DisableBrokenDatatype(syncable::ModelType type, i think usual style ...

8 years, 6 months ago (2012-06-18 22:17:45 UTC) #2

tim (not reviewing)

8 years, 6 months ago (2012-06-18 22:47:53 UTC) #3

http://codereview.chromium.org/10559050/diff/6001/chrome/browser/sync/profile...
File chrome/browser/sync/profile_sync_service.h (right):

http://codereview.chromium.org/10559050/diff/6001/chrome/browser/sync/profile...
chrome/browser/sync/profile_sync_service.h:354: virtual void
DisableBrokenDatatype(syncable::ModelType type,
On 2012/06/18 22:17:45, akalin wrote:
> i think usual style is newline and indent after (

Done.

Expand Messages | Collapse Messages