Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: content/browser/browser_child_process_host_impl.h

Issue 10559047: Small cleanup in BrowserChildProcessHost. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_
6 #define CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_
7 #pragma once 7 #pragma once
8 8
9 #include <list> 9 #include <list>
10 10
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 78
79 typedef std::list<BrowserChildProcessHostImpl*> BrowserChildProcessList; 79 typedef std::list<BrowserChildProcessHostImpl*> BrowserChildProcessList;
80 private: 80 private:
81 friend class content::BrowserChildProcessHostIterator; 81 friend class content::BrowserChildProcessHostIterator;
82 82
83 static BrowserChildProcessList* GetIterator(); 83 static BrowserChildProcessList* GetIterator();
84 84
85 // ChildProcessHostDelegate implementation: 85 // ChildProcessHostDelegate implementation:
86 virtual bool CanShutdown() OVERRIDE; 86 virtual bool CanShutdown() OVERRIDE;
87 virtual void OnChildDisconnected() OVERRIDE; 87 virtual void OnChildDisconnected() OVERRIDE;
88 virtual void ShutdownStarted() OVERRIDE;
89 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 88 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
90 virtual void OnChannelConnected(int32 peer_pid) OVERRIDE; 89 virtual void OnChannelConnected(int32 peer_pid) OVERRIDE;
91 virtual void OnChannelError() OVERRIDE; 90 virtual void OnChannelError() OVERRIDE;
92 91
93 // ChildProcessLauncher::Client implementation. 92 // ChildProcessLauncher::Client implementation.
94 virtual void OnProcessLaunched() OVERRIDE; 93 virtual void OnProcessLaunched() OVERRIDE;
95 94
96 // public base::WaitableEventWatcher::Delegate implementation: 95 // public base::WaitableEventWatcher::Delegate implementation:
97 virtual void OnWaitableEventSignaled( 96 virtual void OnWaitableEventSignaled(
98 base::WaitableEvent* waitable_event) OVERRIDE; 97 base::WaitableEvent* waitable_event) OVERRIDE;
99 98
100 content::ChildProcessData data_; 99 content::ChildProcessData data_;
101 content::BrowserChildProcessHostDelegate* delegate_; 100 content::BrowserChildProcessHostDelegate* delegate_;
102 scoped_ptr<content::ChildProcessHost> child_process_host_; 101 scoped_ptr<content::ChildProcessHost> child_process_host_;
103 102
104 scoped_ptr<ChildProcessLauncher> child_process_; 103 scoped_ptr<ChildProcessLauncher> child_process_;
105 #if defined(OS_WIN) 104 #if defined(OS_WIN)
106 base::WaitableEventWatcher child_watcher_; 105 base::WaitableEventWatcher child_watcher_;
107 #else 106 #else
108 base::WeakPtrFactory<BrowserChildProcessHostImpl> task_factory_; 107 base::WeakPtrFactory<BrowserChildProcessHostImpl> task_factory_;
109 #endif 108 #endif
110 bool disconnect_was_alive_; 109 bool disconnect_was_alive_;
111 }; 110 };
112 111
113 #endif // CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_ 112 #endif // CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698