Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2113)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 10559036: Added URLRequestContext to constructor for URLRequest. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Merged with latest version Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
index 34efed93e8a417f4c89eb36a5eee4897a6c2910a..bae78a47da0b66a748cb0200ae8d57948550962d 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
@@ -167,8 +167,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceRedirect) {
GURL redirect_url("about:redirected");
GURL not_chosen_redirect_url("about:not_chosen");
- net::URLRequest request(GURL("about:blank"), &delegate_);
- request.set_context(context_.get());
+ net::URLRequest request(GURL("about:blank"), &delegate_, context_.get());
{
// onBeforeRequest will be dispatched twice initially. The second response -
// the redirect - should win, since it has a later |install_time|. The
@@ -222,8 +221,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceRedirect) {
}
// Now test the same thing but the extensions answer in reverse order.
- net::URLRequest request2(GURL("about:blank"), &delegate_);
- request2.set_context(context_.get());
+ net::URLRequest request2(GURL("about:blank"), &delegate_, context_.get());
{
ExtensionWebRequestEventRouter::EventResponse* response = NULL;
@@ -296,8 +294,7 @@ TEST_F(ExtensionWebRequestTest, BlockingEventPrecedenceCancel) {
ipc_sender_factory.GetWeakPtr());
GURL request_url("about:blank");
- net::URLRequest request(request_url, &delegate_);
- request.set_context(context_.get());
+ net::URLRequest request(request_url, &delegate_, context_.get());
// onBeforeRequest will be dispatched twice. The second response -
// the redirect - would win, since it has a later |install_time|, but
@@ -364,8 +361,7 @@ TEST_F(ExtensionWebRequestTest, SimulateChancelWhileBlocked) {
filter, 0, ipc_sender_factory.GetWeakPtr());
GURL request_url("about:blank");
- net::URLRequest request(request_url, &delegate_);
- request.set_context(context_.get());
+ net::URLRequest request(request_url, &delegate_, context_.get());
ExtensionWebRequestEventRouter::EventResponse* response = NULL;
@@ -495,8 +491,7 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {
ipc_sender_factory.GetWeakPtr());
GURL request_url("http://doesnotexist/does_not_exist.html");
- net::URLRequest request(request_url, &delegate_);
- request.set_context(context_.get());
+ net::URLRequest request(request_url, &delegate_, context_.get());
// Initialize headers available before extensions are notified of the
// onBeforeSendHeaders event.

Powered by Google App Engine
This is Rietveld 408576698