Implement a simple register allocator that tries to keep instruction results in registers.

runtime/vm/locations.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_LOCATIONS_H_
 #define VM_LOCATIONS_H_
 
 #include "vm/allocation.h"
 #include "vm/assembler.h"
 #include "vm/bitfield.h"
 
 namespace dart {
 
 
-class UnallocatedLocation;
-
 // Location objects are used to connect register allocator and code generator.
 // Instruction templates used by code generator have a corresponding
 // LocationSummary object which specifies expected location for every input
 // and output.
 // Each location is encoded as a single word: low 2 bits denote location kind,
 // rest is kind specific location payload e.g. for REGISTER kind payload is
 // register code (value of the Register enumeration).
 class Location : public ValueObject {
  public:
   enum Kind {
@@ skipping 68 matching lines @@
   typedef BitField<Policy, 0, 1> PolicyField;
 
   // TODO(vegorov): choose fixed size for this field.
   uword value_;
 };
 
 
 // Specification of locations for inputs and output.
 class LocationSummary : public ZoneAllocated {
  public:
-  LocationSummary(intptr_t input_count, intptr_t temp_count)
+  enum ContainsCall {
+    kNoCall,
+    kCall,
+  };
+
+  enum ContainsBranch {
+    kNoBranch,
+    kBranch
+  };
+
+  LocationSummary(intptr_t input_count,
+                  intptr_t temp_count,
+                  ContainsCall call = kNoCall,

[srdjan, 2012/06/18 16:33:20]

I am not sure having default value for 'call' is good. I think it will make the
caller more readable if we clearly state kNoCall where appropriate, so that the
differentiation is visible. 'branch' will go away, so I have no beef with it
having a default value.

[Vyacheslav Egorov (Google), 2012/06/18 17:51:16]

Having default value is definitely less safe than not having one. We can
eliminate it. I am adding todo.

+                  ContainsBranch branch = kNoBranch)
       : input_locations_(input_count),
         temp_locations_(temp_count),
-        output_location_() {
+        output_location_(),
+        is_call_(call == kCall),
+        is_branch_(branch == kBranch) {
     for (intptr_t i = 0; i < input_count; i++) {
       input_locations_.Add(Location());
     }
     for (intptr_t i = 0; i < temp_count; i++) {
       temp_locations_.Add(Location());
     }
   }
 
   intptr_t input_count() const {
     return input_locations_.length();
@@ skipping 20 matching lines @@
   }
 
   Location out() const {
     return output_location_;
   }
 
   void set_out(Location loc) {
     output_location_ = loc;
   }
 
-  // Perform a greedy local register allocation.  Consider all register free.
-  void AllocateRegisters();
+  bool is_call() const {
+    return is_call_;
+  }
 
-  static LocationSummary* Make(intptr_t input_count, Location out);
+  // TODO(vegorov): this is a temporary solution. Once we will start removing
+  // comparison operations from the flow graph when they are fused with a branch
+  // we should eliminate this.
+  bool is_branch() const {
+    return is_branch_;
+  }
+
+  static LocationSummary* Make(intptr_t input_count,
+                               Location out,
+                               ContainsCall contains_call = kNoCall,
+                               ContainsBranch contains_branch = kNoBranch);
 
  private:
   // TODO(vegorov): replace with ZoneArray.
   GrowableArray<Location> input_locations_;
   GrowableArray<Location> temp_locations_;
   Location output_location_;
+
+  const bool is_call_;
+  const bool is_branch_;
 };
 
 
 }  // namespace dart
 
 #endif  // VM_LOCATIONS_H_