Always invoke the default Array.sort functions from builtin functions.

Always invoke the default Array.sort functions from builtin functions.

TEST=mjsunit/regress/regress-builtin-array-op.js
BUG=v8:2372
Committed: https://code.google.com/p/v8/source/detail?r=12752

[Yang, 2012-10-18 10:41:11]

LGTM.

[fschneider, 2012-10-18 11:21:03]

On 2012/10/18 10:41:11, Yang wrote:
> LGTM.

Landed. Thanks for the review!

[Vyacheslav Egorov (Google), 2012-10-19 12:11:50]

DBC :-)

https://chromiumcodereview.appspot.com/10559005/diff/1/src/array.js
File src/array.js (right):

https://chromiumcodereview.appspot.com/10559005/diff/1/src/array.js#newcode65
src/array.js:65: ArraySort.call(keys, function(a, b) { return a - b; });
What happens here if I overwrite Function.prototype.call to do nasty things?

[Yang, 2012-10-19 12:21:53]

On 2012/10/19 12:11:50, Vyacheslav Egorov (Google) wrote:
> DBC :-)
> 
> https://chromiumcodereview.appspot.com/10559005/diff/1/src/array.js
> File src/array.js (right):
> 
> https://chromiumcodereview.appspot.com/10559005/diff/1/src/array.js#newcode65
> src/array.js:65: ArraySort.call(keys, function(a, b) { return a - b; });
> What happens here if I overwrite Function.prototype.call to do nasty things?

Fix coming up.

[Florian Schneider, 2012-10-19 12:22:18]

On 2012/10/19 12:11:50, Vyacheslav Egorov (Google) wrote:
> DBC :-)
> 
> https://chromiumcodereview.appspot.com/10559005/diff/1/src/array.js
> File src/array.js (right):
> 
> https://chromiumcodereview.appspot.com/10559005/diff/1/src/array.js#newcode65
> src/array.js:65: ArraySort.call(keys, function(a, b) { return a - b; });
> What happens here if I overwrite Function.prototype.call to do nasty things?

True, we should use %_CallFunction then.

[Yang, 2012-10-19 12:26:09]

On 2012/10/19 12:22:18, Florian Schneider wrote:
> On 2012/10/19 12:11:50, Vyacheslav Egorov (Google) wrote:
> > DBC :-)
> > 
> > https://chromiumcodereview.appspot.com/10559005/diff/1/src/array.js
> > File src/array.js (right):
> > 
> >
https://chromiumcodereview.appspot.com/10559005/diff/1/src/array.js#newcode65
> > src/array.js:65: ArraySort.call(keys, function(a, b) { return a - b; });
> > What happens here if I overwrite Function.prototype.call to do nasty things?
> 
> True, we should use %_CallFunction then.

--> https://chromiumcodereview.appspot.com/11175007/