Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10558009: [Chrome OS ECHO]: Add favicon and intent handler title. (Closed)

Created:
8 years, 6 months ago by gauravsh
Modified:
8 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Chrome OS ECHO]: Add favicon and intent handler title. BUG=chromium-os:31347 TEST=favicon and title is displayed Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142522

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/chromeos/echo/manifest.json View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
gauravsh
8 years, 6 months ago (2012-06-15 18:22:23 UTC) #1
rginda
lgtm
8 years, 6 months ago (2012-06-15 19:52:08 UTC) #2
Jorge Lucangeli Obes
lgtm
8 years, 6 months ago (2012-06-15 21:37:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/10558009/1001
8 years, 6 months ago (2012-06-15 22:34:45 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-15 23:37:32 UTC) #5
Change committed as 142522

Powered by Google App Engine
This is Rietveld 408576698