Further extend TypedArray support in d8:

Further extend TypedArray support in d8:

- Add copy constructors.
- Add subarray methods.
- Make instanceof and constructor property work.
- Rename PixelArray to Uint8ClampedArray.

Also fix broken definition of assertInstanceof in MJSUnit test harness.

R=mstarzinger@chromium.org
BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=11949

[Michael Starzinger, 2012-06-25 09:56:45]

LGTM (with a few nits).

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc#newcode444
src/d8.cc:444: !args[0]->ToObject()->GetHiddenValue(
Indentation seems off.

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc#newcode482
src/d8.cc:482: if (args[0]->IsObject() &&
Can we make this a proper "else if" so that all cases are on the same nesting
level?

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc#newcode501
src/d8.cc:501: ARRAY_SIZE(buffer_args), buffer_args);
Indentation seems off.

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.h
File src/d8.h (right):

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.h#newcode398
src/d8.h:398: static Handle<Value> CreateExternalArray(const Arguments& args,
Shouldn't this one actually return Handle<Object> as well?

https://chromiumcodereview.appspot.com/10558005/diff/1/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (left):

https://chromiumcodereview.appspot.com/10558005/diff/1/test/mjsunit/mjsunit.j...
test/mjsunit/mjsunit.js:324: var actualConstructor =
Object.prototypeOf(obj).constructor;
How did that even ... ah forget it.

[rossberg, 2012-06-28 16:23:34]

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc#newcode444
src/d8.cc:444: !args[0]->ToObject()->GetHiddenValue(
On 2012/06/25 09:56:45, Michael Starzinger wrote:
> Indentation seems off.

Done.

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc#newcode482
src/d8.cc:482: if (args[0]->IsObject() &&
On 2012/06/25 09:56:45, Michael Starzinger wrote:
> Can we make this a proper "else if" so that all cases are on the same nesting
> level?

Note sure what you're suggesting exactly -- IIUC, that would require duplicating
all the code after the inner `if'.

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc#newcode501
src/d8.cc:501: ARRAY_SIZE(buffer_args), buffer_args);
On 2012/06/25 09:56:45, Michael Starzinger wrote:
> Indentation seems off.

Done.

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.h
File src/d8.h (right):

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.h#newcode398
src/d8.h:398: static Handle<Value> CreateExternalArray(const Arguments& args,
On 2012/06/25 09:56:45, Michael Starzinger wrote:
> Shouldn't this one actually return Handle<Object> as well?

Can't unfortunately, because ThrowException returns a Handle<Value> (that one
could actually be made into a template, but doesn't seem worth it...).

https://chromiumcodereview.appspot.com/10558005/diff/1/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (left):

https://chromiumcodereview.appspot.com/10558005/diff/1/test/mjsunit/mjsunit.j...
test/mjsunit/mjsunit.js:324: var actualConstructor =
Object.prototypeOf(obj).constructor;
On 2012/06/25 09:56:45, Michael Starzinger wrote:
> How did that even ... ah forget it.

Great stuff, isn't it?

[Michael Starzinger, 2012-06-28 16:26:03]

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10558005/diff/1/src/d8.cc#newcode482
src/d8.cc:482: if (args[0]->IsObject() &&
On 2012/06/28 16:23:34, rossberg wrote:
> On 2012/06/25 09:56:45, Michael Starzinger wrote:
> > Can we make this a proper "else if" so that all cases are on the same
nesting
> > level?
> 
> Note sure what you're suggesting exactly -- IIUC, that would require
duplicating
> all the code after the inner `if'.

You are right, I screwed up the nesting levels in my head. Sorry for that.