Issue 10557041: Patch NaCl gcc to avoid use of fsincos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10557041: Patch NaCl gcc to avoid use of fsincos. (Closed)

Created:
8 years, 6 months ago by khim

Modified:
8 years, 6 months ago

Reviewers:
pasko-google - do not use

CC:
native-client-reviews_googlegroups.com, Brad Chen

Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master

Visibility:
Public.

Patch NaCl gcc to avoid use of fsincos. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2720 TEST=bots R=pasko@google.com Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=455063d

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	gcc/config/i386/i386.md	View	1	2 chunks	+26 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

pasko-google - do not use

8 years, 6 months ago (2012-06-18 18:22:39 UTC) #2

LGTM

Brad, FYI: there is a GCC builtin that could generate the fun instruction. Now
Victor has disabled it.