Do not set the appid and window icon in Metro

Do not set the appid and window icon in Metro

Patch From Gabriel Charette <gab@chromium.org>; 
BUG=None
TEST=Launch Chrome Metro from Start Screen with Chrome as default.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142910

[sky, 2012-06-15 21:14:32]

https://chromiumcodereview.appspot.com/10557017/diff/3001/chrome/browser/ui/b...
File chrome/browser/ui/browser.cc (right):

https://chromiumcodereview.appspot.com/10557017/diff/3001/chrome/browser/ui/b...
chrome/browser/ui/browser.cc:539: if (!base::win::GetMetroModule()) {
Why is this here and not in BrowserView or preferably BrowserFrameWin?

[cpu_(ooo_6.6-7.5), 2012-06-18 21:54:49]

lgtm. I let others hash out what place is better for this code to live.

[gab, 2012-06-18 21:57:38]

On 2012/06/18 21:54:49, cpu wrote:
> lgtm. I let others hash out what place is better for this code to live.

Thanks, this CL is only trying to fix something that is wrong before M21.
Whether the SetAppId code belongs there or not is debatable, but shouldn't block
us from adding this check for M21 imo.

@sky: would you be ok with a TODO or opening a bug for moving this? I don't have
time to otherwise modify this before M21 (crunch mode on some other M21 CLs
right now).

[sky, 2012-06-18 23:12:27]

LGTM with a TODO and that you'll cleanup soonish.

[gab, 2012-06-18 23:37:43]

Moved logic in ui::win::SetAppIdAndIconForWindow() instead as, for one, there
were other callers of this function that would have needed to be fixed as well.

The logic to not do this in Metro belongs right here with the logic not to do
this in Win7- imo.

PTAL.

Thanks,
Gab

[sky, 2012-06-18 23:45:26]

LGTM

[commit-bot: I haz the power, 2012-06-19 00:33:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/10557017/9001

[commit-bot: I haz the power, 2012-06-19 03:39:36]

Try job failure for 10557017-9001 (retry) on win_rel for step
"chrome_frame_net_tests".
It's a second try, previously, step "chrome_frame_net_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-06-19 04:03:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/10557017/9001