lib/compiler/implementation/operations.dart - Issue 10557003: Fix most warnings and other minor cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/operations.dart

Issue 10557003: Fix most warnings and other minor cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/operations.dart

diff --git a/lib/compiler/implementation/operations.dart b/lib/compiler/implementation/operations.dart

index e445678aa319176291d85c1692f5c8186a78a436..3bd11b8b52bcbd2d19d6b989e7d1d3cc50d5e3c7 100644

--- a/lib/compiler/implementation/operations.dart

+++ b/lib/compiler/implementation/operations.dart

@@ -235,8 +235,7 @@ class AddOperation implements BinaryOperation {

if (rightDartString.isEmpty()) {

return left;

} else if (leftString.value.isEmpty()) {

- // TODO(floitsch): There is no right.node. Find a node some other way.

- return new StringConstant(rightDartString, right.node);

+ return new StringConstant(rightDartString, leftString.node);

} else {

DartString concatenated =

new ConsDartString(leftString.value, rightDartString);