Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10557003: Fix most warnings and other minor cleanups. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/dart_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compiler.dart
diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart
index afc6146a8de6b700c1aabf4723fd20e30cc94d49..f7c4739d2b6e162b693c8105f0aa0c650d90e3b4 100644
--- a/lib/compiler/implementation/compiler.dart
+++ b/lib/compiler/implementation/compiler.dart
@@ -45,7 +45,8 @@ class Backend {
abstract void enqueueHelpers(Enqueuer world);
abstract String codegen(WorkItem work);
- abstract void processNativeClasses(world, libraries);
+ abstract void processNativeClasses(Enqueuer world,
+ Collection<LibraryElement> libraries);
abstract void assembleProgram();
abstract List<CompilerTask> get tasks();
}
@@ -92,7 +93,8 @@ class JavaScriptBackend extends Backend {
return generator.generateMethod(work, graph);
}
- void processNativeClasses(world, libraries) {
+ void processNativeClasses(Enqueuer world,
+ Collection<LibraryElement> libraries) {
native.processNativeClasses(world, emitter, libraries);
}
@@ -437,7 +439,7 @@ class Compiler implements DiagnosticListener {
checkQueues();
}
- processQueue(Enqueuer world, Element main) {
+ void processQueue(Enqueuer world, Element main) {
backend.processNativeClasses(world, libraries.getValues());
world.addToWorkList(main);
codegenProgress.reset();
@@ -449,7 +451,7 @@ class Compiler implements DiagnosticListener {
world.registerFieldClosureInvocations();
}
- processRecompilationQueue(Enqueuer world) {
+ void processRecompilationQueue(Enqueuer world) {
pass = 2;
while (!world.recompilationCandidates.isEmpty()) {
WorkItem work = world.recompilationCandidates.next();
@@ -472,7 +474,7 @@ class Compiler implements DiagnosticListener {
* were resolved, but not compiled (aka excess resolution).
*/
checkQueues() {
- for (var world in [enqueuer.resolution, enqueuer.codegen]) {
+ for (Enqueuer world in [enqueuer.resolution, enqueuer.codegen]) {
world.forEach((WorkItem work) {
internalErrorOnElement(work.element, "Work list is not empty.");
});
@@ -490,7 +492,8 @@ class Compiler implements DiagnosticListener {
resolved.remove(e);
}
if (e.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
- if (e.enclosingElement.isInterface()) {
+ ClassElement enclosingClass = e.enclosingElement;
+ if (enclosingClass.isInterface()) {
resolved.remove(e);
}
resolved.remove(e);
« no previous file with comments | « no previous file | lib/compiler/implementation/dart_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698