Fix most warnings and other minor cleanups.

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 484 matching lines @@
     // Check that the operation is one of +, *, - or /. Record whether
     // or not the operation is commutative.
     var isCommutative = false;
     if (instruction is HAdd || instruction is HMultiply) {
       isCommutative = true;
     } else if (instruction is !HSubtract && instruction is !HDivide) {
       return false;
     }
 
     // Is it a builtin operation involving +, -, /, or *?
-    if (instruction.builtin && instruction.inputs.length == 3) {
-      var left = instruction.inputs[1];
-      var right = instruction.inputs[2];
+    HBinaryArithmetic binaryInstruction = instruction;
+    assert(binaryInstruction.inputs.length == 3);
+    if (binaryInstruction.builtin) {
+      var left = binaryInstruction.left;
+      var right = binaryInstruction.right;
       if (isCommutative && variableNames.getName(right) == name) {
         var tmp = right;
         right = left;
         left = tmp;
       }
 
       // Check that left has the same name as the definition and emit
       // the short update definition if it is.
       if (variableNames.getName(left) == name) {
         // Check if the right operand is constant one.
         bool rightIsOne = false;
         if (right.isConstantNumber()) {
           HConstant rightConstant = right;
-          rightIsOne = (rightConstant.constant.value == 1);
+          NumConstant numConstant = rightConstant.constant;
+          rightIsOne = (numConstant.value == 1);
         }
-        if (instruction is HAdd && rightIsOne) {
+        if (binaryInstruction is HAdd && rightIsOne) {
           beginExpression(JSPrecedence.PREFIX_PRECEDENCE);
           buffer.add('++');
           declareVariable(name);
           endExpression(JSPrecedence.PREFIX_PRECEDENCE);
-        } else if (instruction is HSubtract && rightIsOne) {
+        } else if (binaryInstruction is HSubtract && rightIsOne) {
           beginExpression(JSPrecedence.PREFIX_PRECEDENCE);
           buffer.add('--');
           declareVariable(name);
           endExpression(JSPrecedence.PREFIX_PRECEDENCE);
         } else {
-          var operation = instruction.operation.name;
+          var operation = binaryInstruction.operation.name;
           beginExpression(JSPrecedence.ASSIGNMENT_PRECEDENCE);
           declareVariable(name);
           buffer.add(' ${operation}= ');
           use(right, JSPrecedence.ASSIGNMENT_PRECEDENCE);
           endExpression(JSPrecedence.ASSIGNMENT_PRECEDENCE);
         }
         return true;
       }
     }
     return false;
@@ skipping 1939 matching lines @@
   }
 
   int maxBailoutParameters;
 
   HBasicBlock beginGraph(HGraph graph) => graph.entry;
   void endGraph(HGraph graph) {}
 
   void bailout(HTypeGuard guard, String reason) {
     if (maxBailoutParameters === null) {
       maxBailoutParameters = 0;
-      work.guards.forEach((HTypeGuard guard) {
-        int inputLength = guard.inputs.length;
+      work.guards.forEach((HTypeGuard workGuard) {
+        int inputLength = workGuard.inputs.length;
         if (inputLength > maxBailoutParameters) {
           maxBailoutParameters = inputLength;
         }
       });
     }
     HInstruction input = guard.guarded;
     Namer namer = compiler.namer;
     Element element = work.element;
     buffer.add('return ');
     if (element.isInstanceMember()) {
@@ skipping 403 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     if (labeledBlockInfo.body.start.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }