Fix most warnings and other minor cleanups.

lib/compiler/implementation/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
 final bool REPORT_EXCESS_RESOLUTION = false;
@@ skipping 27 matching lines @@
   Backend(this.compiler);
 
   void enqueueAllTopLevelFunctions(LibraryElement lib, Enqueuer world) {
     lib.forEachExport((Element e) {
       if (e.isFunction()) world.addToWorkList(e);
     });
   }
 
   abstract void enqueueHelpers(Enqueuer world);
   abstract String codegen(WorkItem work);
-  abstract void processNativeClasses(world, libraries);
+  abstract void processNativeClasses(Enqueuer world,
+                                     Collection<LibraryElement> libraries);
   abstract void assembleProgram();
   abstract List<CompilerTask> get tasks();
 }
 
 class JavaScriptBackend extends Backend {
   SsaBuilderTask builder;
   SsaOptimizerTask optimizer;
   SsaCodeGeneratorTask generator;
   CodeEmitterTask emitter;
 
@@ skipping 26 matching lines @@
     if (work.allowSpeculativeOptimization
         && optimizer.trySpeculativeOptimizations(work, graph)) {
       String code = generator.generateBailoutMethod(work, graph);
       compiler.codegenWorld.addBailoutCode(work, code);
       optimizer.prepareForSpeculativeOptimizations(work, graph);
       optimizer.optimize(work, graph);
     }
     return generator.generateMethod(work, graph);
   }
 
-  void processNativeClasses(world, libraries) {
+  void processNativeClasses(Enqueuer world,
+                            Collection<LibraryElement> libraries) {
     native.processNativeClasses(world, emitter, libraries);
   }
 
   void assembleProgram() {
     emitter.assembleProgram();
   }
 }
 
 class Compiler implements DiagnosticListener {
   final Map<String, LibraryElement> libraries;
@@ skipping 324 matching lines @@
     log("Recompiling ${enqueuer.codegen.recompilationCandidates.length} "
         "methods...");
     processRecompilationQueue(enqueuer.codegen);
     log('Compiled ${codegenWorld.generatedCode.length} methods.');
 
     backend.assembleProgram();
 
     checkQueues();
   }
 
-  processQueue(Enqueuer world, Element main) {
+  void processQueue(Enqueuer world, Element main) {
     backend.processNativeClasses(world, libraries.getValues());
     world.addToWorkList(main);
     codegenProgress.reset();
     world.forEach((WorkItem work) {
       withCurrentElement(work.element, () => work.run(this, world));
     });
     world.queueIsClosed = true;
     assert(world.checkNoEnqueuedInvokedInstanceMethods());
     world.registerFieldClosureInvocations();
   }
 
-  processRecompilationQueue(Enqueuer world) {
+  void processRecompilationQueue(Enqueuer world) {
     pass = 2;
     while (!world.recompilationCandidates.isEmpty()) {
       WorkItem work = world.recompilationCandidates.next();
       var oldCode = world.universe.generatedCode[work.element];
       world.universe.generatedCode.remove(work.element);
       withCurrentElement(work.element, () => work.run(this, world));
       var newCode = world.universe.generatedCode[work.element];
       if (REPORT_PASS2_OPTIMIZATIONS && newCode != oldCode) {
         log("Pass 2 optimization:");
         log("Before:\n$oldCode");
         log("After:\n$newCode");
       }
     }
   }
 
   /**
    * Perform various checks of the queues. This includes checking that
    * the queues are empty (nothing was added after we stopped
    * processing the queues). Also compute the number of methods that
    * were resolved, but not compiled (aka excess resolution).
    */
   checkQueues() {
-    for (var world in [enqueuer.resolution, enqueuer.codegen]) {
+    for (Enqueuer world in [enqueuer.resolution, enqueuer.codegen]) {
       world.forEach((WorkItem work) {
         internalErrorOnElement(work.element, "Work list is not empty.");
       });
     }
     var resolved = new Set.from(enqueuer.resolution.resolvedElements.getKeys());
     for (Element e in codegenWorld.generatedCode.getKeys()) {
       resolved.remove(e);
     }
     for (Element e in new Set.from(resolved)) {
       if (e.isClass() ||
           e.isField() ||
           e.isTypeVariable() ||
           e.isTypedef() ||
           e.kind === ElementKind.ABSTRACT_FIELD) {
         resolved.remove(e);
       }
       if (e.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
-        if (e.enclosingElement.isInterface()) {
+        ClassElement enclosingClass = e.enclosingElement;
+        if (enclosingClass.isInterface()) {
           resolved.remove(e);
         }
         resolved.remove(e);
 
       }
       if (e.getLibrary() === jsHelperLibrary) {
         resolved.remove(e);
       }
       if (e.getLibrary() === interceptorsLibrary) {
         resolved.remove(e);
@@ skipping 234 matching lines @@
     // invariant that endOffset > beginOffset, but for EOF the
     // charoffset of the next token may be [beginOffset]. This can
     // also happen for synthetized tokens that are produced during
     // error handling.
     final endOffset =
       Math.max((end.next !== null) ? end.next.charOffset : 0, beginOffset + 1);
     assert(endOffset > beginOffset);
     return f(beginOffset, endOffset);
   }
 }